Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(window): Fixed window.component.ts creating incorrect context #1266

Merged
merged 4 commits into from
Mar 17, 2019

Conversation

aefox
Copy link
Contributor

@aefox aefox commented Feb 27, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

This fixes #1261. The issue was related to the context for a template being correctly created in windowService but window.component was also creating a wrapper around it { $implicit: this.context }

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #1266 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
+ Coverage   80.59%   80.65%   +0.05%     
==========================================
  Files         232      232              
  Lines        7051     7051              
  Branches      592      592              
==========================================
+ Hits         5683     5687       +4     
+ Misses       1192     1190       -2     
+ Partials      176      174       -2
Impacted Files Coverage Δ
...ramework/theme/components/window/window.service.ts 98.41% <100%> (+1.58%) ⬆️
...mework/theme/components/window/window.component.ts 84.48% <100%> (+5.17%) ⬆️

package-lock.json Outdated Show resolved Hide resolved
@yggg yggg merged commit 30f4a5d into akveo:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbWindowService - context no longer works
2 participants