Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(theme): remove use of scss-functions #1256

Merged
merged 2 commits into from
Mar 21, 2019
Merged

refactor(theme): remove use of scss-functions #1256

merged 2 commits into from
Mar 21, 2019

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Feb 21, 2019 •
edited
Loading

BREAKING CHANGES:

  • calendar - use primary button in cosmic theme
  • checkbox - opacity instead of lightning
  • context-menu, popover, datepicker - calc instead of round and scss calculations
  • input - opacity for placeholder instead of lightning
  • tabs - remove gradient for tab bottom separator in cosmic theme
  • toastr - use background-color instead of gradient in cosmic theme
  • text colors are now used from success/primary/warning/etc colors
  • add color palett instead of generating colors using scss-functions, example for primary
    color-primary-200
    color-primary-300
    color-primary-400
    color-primary-600
    color-primary-700

and create-colors-palette() scss function that can be used during theme installation process to generate palette automatically

Closes #1228

@nnixaa nnixaa requested review from yggg and Tibing and removed request for yggg February 28, 2019 08:30
@nnixaa nnixaa added this to In progress in Nebular via automation Feb 28, 2019
@nnixaa nnixaa moved this from In progress to Needs review in Nebular Feb 28, 2019
@nnixaa nnixaa marked this pull request as ready for review February 28, 2019 08:45
@nnixaa nnixaa requested a review from yggg February 28, 2019 10:07
@nnixaa nnixaa force-pushed the feat/theme-css-system-new branch from 5a42d58 to 1d8cf3c Compare March 1, 2019 17:29
yggg
yggg reviewed Mar 14, 2019
View reviewed changes
src/framework/theme/styles/_theming.scss
@each $key, $degree in $color-keys {
$color: map-get($theme, $key);

$color-300: tint($color, 14%);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't tint, mix etc. be removed as well? And I can't find usages of create-colors-palette function.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function allows generating colors from existing ones. We need to add it to the migration guide #1309.

@nnixaa nnixaa changed the base branch from master to feat/4.0 March 21, 2019 13:48
@nnixaa nnixaa changed the base branch from feat/4.0 to master March 21, 2019 13:49
@nnixaa nnixaa changed the base branch from master to feat/4.0 March 21, 2019 13:49
@nnixaa
refactor(theme): remove use of scss-functions
fe676be 
BREAKING CHANGES:
- calendar - use primary button in cosmic theme
- checkbox - `opacity` instead of `lightning`
- context-menu, popover, datepicker - `calc` instead of `round` and scss calculations
- input - `opacity` for placeholder instead of `lightning`
- tabs - remove gradient for tab bottom separator in cosmic theme
- toastr - use `background-color` instead of gradient in cosmic theme
- text colors are now used from success/primary/warning/etc colors
- add color palett instead of generating colors using scss-functions, example for `primary`
`color-primary-200`
`color-primary-300`
`color-primary-400`
`color-primary-600`
`color-primary-700`

and create-colors-palette() scss function that can be used during theme installation process to generate palette automatically
@nnixaa
fix(bootstrap): include style changes into bootstrap package
7bcd5c7
@nnixaa nnixaa merged commit 21c02b9 into feat/4.0 Mar 21, 2019
Nebular automation moved this from Needs review to Done Mar 21, 2019
yggg pushed a commit that referenced this pull request Mar 28, 2019
@nnixaa @yggg
refactor(theme): remove use of scss functions (#1256)
93e29ef 
BREAKING CHANGES:
- calendar - use primary button in cosmic theme
- checkbox - `opacity` instead of `lightning`
- context-menu, popover, datepicker - `calc` instead of `round` and scss calculations
- input - `opacity` for placeholder instead of `lightning`
- tabs - remove gradient for tab bottom separator in cosmic theme
- toastr - use `background-color` instead of the gradient in cosmic theme
- text colors are now used from success/primary/warning/etc colors
- add color palette instead of generating colors using scss-functions, an example for `primary`
`color-primary-200`
`color-primary-300`
`color-primary-400`
`color-primary-600`
`color-primary-700`

`create-colors-palette()` scss function that can be used during the theme installation process to generate palette automatically

Closes #1228
nnixaa added a commit that referenced this pull request Apr 1, 2019
@nnixaa
refactor(theme): remove use of scss functions (#1256)
164a0c8 
BREAKING CHANGES:
- calendar - use primary button in cosmic theme
- checkbox - `opacity` instead of `lightning`
- context-menu, popover, datepicker - `calc` instead of `round` and scss calculations
- input - `opacity` for placeholder instead of `lightning`
- tabs - remove gradient for tab bottom separator in cosmic theme
- toastr - use `background-color` instead of the gradient in cosmic theme
- text colors are now used from success/primary/warning/etc colors
- add color palette instead of generating colors using scss-functions, an example for `primary`
`color-primary-200`
`color-primary-300`
`color-primary-400`
`color-primary-600`
`color-primary-700`

`create-colors-palette()` scss function that can be used during the theme installation process to generate palette automatically

Closes #1228
brannon-darby pushed a commit to brannon-darby/nebular that referenced this pull request Apr 5, 2019
@nnixaa @brannon-darby
refactor(theme): remove use of scss functions (akveo#1256)
4823607 
BREAKING CHANGES:
- calendar - use primary button in cosmic theme
- checkbox - `opacity` instead of `lightning`
- context-menu, popover, datepicker - `calc` instead of `round` and scss calculations
- input - `opacity` for placeholder instead of `lightning`
- tabs - remove gradient for tab bottom separator in cosmic theme
- toastr - use `background-color` instead of the gradient in cosmic theme
- text colors are now used from success/primary/warning/etc colors
- add color palette instead of generating colors using scss-functions, an example for `primary`
`color-primary-200`
`color-primary-300`
`color-primary-400`
`color-primary-600`
`color-primary-700`

`create-colors-palette()` scss function that can be used during the theme installation process to generate palette automatically

Closes akveo#1228
brannon-darby pushed a commit to brannon-darby/nebular that referenced this pull request Apr 5, 2019
@nnixaa @brannon-darby
refactor(theme): remove use of scss functions (akveo#1256)
750df31 
BREAKING CHANGES:
- calendar - use primary button in cosmic theme
- checkbox - `opacity` instead of `lightning`
- context-menu, popover, datepicker - `calc` instead of `round` and scss calculations
- input - `opacity` for placeholder instead of `lightning`
- tabs - remove gradient for tab bottom separator in cosmic theme
- toastr - use `background-color` instead of the gradient in cosmic theme
- text colors are now used from success/primary/warning/etc colors
- add color palette instead of generating colors using scss-functions, an example for `primary`
`color-primary-200`
`color-primary-300`
`color-primary-400`
`color-primary-600`
`color-primary-700`

`create-colors-palette()` scss function that can be used during the theme installation process to generate palette automatically

Closes akveo#1228
yggg pushed a commit that referenced this pull request Apr 17, 2019
@nnixaa @yggg
refactor(theme): remove use of scss functions (#1256)
4f6d000 
BREAKING CHANGES:
- calendar - use primary button in cosmic theme
- checkbox - `opacity` instead of `lightning`
- context-menu, popover, datepicker - `calc` instead of `round` and scss calculations
- input - `opacity` for placeholder instead of `lightning`
- tabs - remove gradient for tab bottom separator in cosmic theme
- toastr - use `background-color` instead of the gradient in cosmic theme
- text colors are now used from success/primary/warning/etc colors
- add color palette instead of generating colors using scss-functions, an example for `primary`
`color-primary-200`
`color-primary-300`
`color-primary-400`
`color-primary-600`
`color-primary-700`

`create-colors-palette()` scss function that can be used during the theme installation process to generate palette automatically

Closes #1228
yggg pushed a commit that referenced this pull request May 27, 2019
@nnixaa @yggg
refactor(theme): remove use of scss functions (#1256)
fa8d87f 
BREAKING CHANGES:
- calendar - use primary button in cosmic theme
- checkbox - `opacity` instead of `lightning`
- context-menu, popover, datepicker - `calc` instead of `round` and scss calculations
- input - `opacity` for placeholder instead of `lightning`
- tabs - remove gradient for tab bottom separator in cosmic theme
- toastr - use `background-color` instead of the gradient in cosmic theme
- text colors are now used from success/primary/warning/etc colors
- add color palette instead of generating colors using scss-functions, an example for `primary`
`color-primary-200`
`color-primary-300`
`color-primary-400`
`color-primary-600`
`color-primary-700`

`create-colors-palette()` scss function that can be used during the theme installation process to generate palette automatically

Closes #1228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yggg yggg yggg left review comments

@Tibing Tibing Awaiting requested review from Tibing

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Nebular
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nnixaa @yggg