Passing Context to NbDialog Component

[sasikumardr]

Issue type

I'm submitting a ... (check one with "x")

• bug report
• feature request

Issue description

Current behavior:

When passing component as first parameter in NbDialogService.open, I am not able to provide certain properties of component in context property of NbDialogConfig. Typescript complaints that other properties and methods of component are missing in the context.

Expected behavior:

We should be able to pass certain component properties in context

Steps to reproduce:

please check this file in stackblitz
https://stackblitz.com/edit/github-id5yop?file=src%2Fapp%2Fhome%2Fhome.component.ts

Proposed Fix:

in src/framework/theme/components/dialog/dialog.service.ts

From

open<T>(content: Type<T> | TemplateRef<T>, userConfig: Partial<NbDialogConfig<T>> = {}): NbDialogRef<T> {

To (use Partial of dialog Component in userConfig property)

open<T>(content: Type<T> | TemplateRef<T>, userConfig: Partial<NbDialogConfig<Partial<T>>> = {}): NbDialogRef<T> {

[sasikumardr]

Hi @nnixaa, fix for this appears to be a single line change as shown in the PR. Could we include this in 3.2 milestone? Currently I am using this in one of my development project and using dirty hack on d.ts in node-modules for making the error free for typescript. So far everything worked fine here.

If there is more for this fix please let me know. I'll look in to it.