fix(router-tabset): navigate using router link #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigation already handled by routerLink directive.
It's doesn't work since angular picks only last router outlet.
Makes navigation work in both playground and doc apps.
Have to split enabled and disabled links into different templates. Otherwise, disabled link can become active because of route match. It's impossible to set route to something that didn't match ever, even [], null, '' match when at the root.
Codecov Report
@@ Coverage Diff @@
## master #1146 +/- ##
==========================================
+ Coverage 79.08% 79.12% +0.03%
==========================================
Files 200 200
Lines 6106 6102 -4
Branches 475 474 -1
==========================================
- Hits 4829 4828 -1
+ Misses 1157 1154 -3
Partials 120 120
|
nnixaa
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fixes #188