Feat/context menu trigger #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(overlay): trigger strategy builder is a service now * refactor(overlay): remove document setter * refactor(popover): rename mode to trigger, deprecate mode * feat(overlay): noop trigger * docs(popover): add noop example
nnixaa
force-pushed
the
feat/context-menu-trigger
branch
from
e100177
to
44e348a
Compare
Tibing
requested changes
Jan 9, 2019
| @@ -201,7 +201,7 @@ export class NbTriggerStrategyBuilderService { | |||
| protected _container: () => ComponentRef<any>; | |||
| protected _trigger: NbTrigger; | |||
|
|
|||
| constructor(@Inject(NB_DOCUMENT) protected _document) { | |||
| constructor(@Inject(NB_DOCUMENT) protected _document: Document) { | |||
There was a problem hiding this comment.
Are you sure we'll not have any issues with the Document token in aot mode?
Tibing
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1112