Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth2 strategy: query parameters in x-www-form-urlencoded #1066

Merged
merged 3 commits into from
Dec 29, 2018

Conversation

visyone
Copy link
Contributor

@visyone visyone commented Dec 12, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

According RFC 6749, all oauth2 flow sends parameters in x-www-form-url-encoded format

@visyone
Copy link
Contributor Author

visyone commented Dec 19, 2018

Hi, there is a chance that this changes will be merged in master and available in next release?

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #1066 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
+ Coverage    76.6%   76.62%   +0.01%     
==========================================
  Files         200      200              
  Lines        6062     6066       +4     
  Branches      465      467       +2     
==========================================
+ Hits         4644     4648       +4     
  Misses       1308     1308              
  Partials      110      110
Impacted Files Coverage Δ
...ramework/auth/strategies/oauth2/oauth2-strategy.ts 84.56% <100%> (+0.42%) ⬆️

@nnixaa nnixaa merged commit 3ee11f2 into akveo:master Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants