Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): resubscribe on options changes #1009

Merged
merged 2 commits into from
Nov 29, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Nov 22, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #931
Closes #948

@Tibing Tibing requested a review from nnixaa November 22, 2018 11:41
@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #1009 into master will decrease coverage by <.01%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
- Coverage   76.89%   76.88%   -0.01%     
==========================================
  Files         200      200              
  Lines        5963     5975      +12     
  Branches      454      455       +1     
==========================================
+ Hits         4585     4594       +9     
- Misses       1271     1273       +2     
- Partials      107      108       +1
Impacted Files Coverage Δ
...mework/theme/components/select/option.component.ts 92.3% <66.66%> (-4.76%) ⬇️
...mework/theme/components/select/select.component.ts 84.23% <90%> (+0.05%) ⬆️

@nnixaa
Copy link
Collaborator

nnixaa commented Nov 22, 2018

LGTM

@Dhanushka-Sasanka
Copy link

<nb-select id="paymentMethod" formControlName="paymentMethod" fullWidth size="small"
                               (selectedChange)="getSelectedPaymentMethod($event)">
                      <nb-option *ngFor="let paymentType of paymentTypes"
                                 [value]="paymentType.id"  >{{paymentType.paymentTypeName}}
                      </nb-option>
</nb-select>

This way is working fine for me ...!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nb-Select not emitting change event NbSelectComponent doesn't detect changes on options
3 participants