Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): add scrollBottom chat option #1001

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Nov 19, 2018

No description provided.

So that it is possible to control `scroll to bottom` reaction on a new message
Also closes #921
@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #1001 into master will decrease coverage by 0.06%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
- Coverage   76.95%   76.89%   -0.07%     
==========================================
  Files         200      200              
  Lines        5954     5963       +9     
  Branches      453      454       +1     
==========================================
+ Hits         4582     4585       +3     
- Misses       1265     1271       +6     
  Partials      107      107
Impacted Files Coverage Δ
.../framework/theme/components/chat/chat.component.ts 62.31% <38.46%> (-4.35%) ⬇️

@nnixaa nnixaa merged commit d393f33 into master Nov 20, 2018
@nnixaa nnixaa deleted the fix/chat-new-message branch November 20, 2018 10:50
rubenXaus pushed a commit to rubenXaus/nebular that referenced this pull request Nov 23, 2018
So that it is possible to control `scroll to bottom` reaction on a new message
Also closes akveo#921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant