Skip to content

Commit

Permalink
fix(context menu): don't close on item click with noop strategy (#2875)
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
Context menu won't close on menu item click is trigger strategy is set to `noop` (`nbContextMenuTrigger="noop"`).
  • Loading branch information
katebatura committed Nov 15, 2021
1 parent 6fff6c3 commit a76fccf
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ export class NbContextMenuDirective implements NbDynamicOverlayController, OnCha
private subscribeOnItemClick() {
this.menuService.onItemClick()
.pipe(
filter(({ tag }) => tag === this.tag),
filter(({ tag }) => tag === this.tag && this.trigger !== NbTrigger.NOOP),
takeUntil(this.destroy$),
)
.subscribe(() => this.hide());
Expand Down

0 comments on commit a76fccf

Please sign in to comment.