fix(datepicker): check trigger strategy is defined before destroying (#…

…2011)
akveo · Oct 10, 2019 · a678e60 · a678e60
1 parent 4114ad1
commit a678e60
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/framework/theme/components/datepicker/datepicker.component.ts b/src/framework/theme/components/datepicker/datepicker.component.ts
@@ -259,7 +259,9 @@ export abstract class NbBasePicker<D, T, P>
  this.ref.dispose();
  }
 
- this.triggerStrategy.destroy();
+ if (this.triggerStrategy) {
+ this.triggerStrategy.destroy();
+ }
  }
 
  /**

diff --git a/src/framework/theme/components/datepicker/datepicker.spec.ts b/src/framework/theme/components/datepicker/datepicker.spec.ts
@@ -84,6 +84,11 @@ describe('nb-datepicker', () => {
  input = fixture.nativeElement.querySelector('input');
  });
 
+ it('should not throw when destroyed right after creation', () => {
+ const picker = TestBed.createComponent(NbDatepickerComponent).componentInstance;
+ expect(picker.ngOnDestroy.bind(picker)).not.toThrow();
+ });
+
  it('should render calendar', () => {
  showDatepicker();
  const calendar = overlay.querySelector('nb-calendar');