Skip to content

Commit

Permalink
refactor(menu): emit itemClick event after clicking on item with link (
Browse files Browse the repository at this point in the history
…#728)

BREAKING CHANGE:

`NbMenuComponent` and `NbContextMenuDirective` now fire itemClick even if item with `routerLink` was clicked.

Closes #423
  • Loading branch information
tibing-old-email authored and nnixaa committed Sep 20, 2018
1 parent 9c22a52 commit 94342e0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/framework/theme/components/menu/menu-item.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
[attr.target]="menuItem.target"
[attr.title]="menuItem.title"
[class.active]="menuItem.selected"
(mouseenter)="onHoverItem(menuItem)">
(mouseenter)="onHoverItem(menuItem)"
(click)="onItemClick(menuItem);">
<i class="menu-icon {{ menuItem.icon }}" *ngIf="menuItem.icon"></i>
<span class="menu-title">{{ menuItem.title }}</span>
</a>
Expand Down

0 comments on commit 94342e0

Please sign in to comment.