feat(tooltip, popover): remove ability to use falsy adjustment (#2619)

BREAKING CHANGE: Falsy adjustment values no longer become converted to `NbAdjustment.NOOP`, pass `NbAdjustment.NOOP` instead.
akveo · Dec 16, 2020 · 32ab00e · 32ab00e
1 parent 0380050
commit 32ab00e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/src/framework/theme/components/popover/popover.directive.ts b/src/framework/theme/components/popover/popover.directive.ts
@@ -154,12 +154,6 @@ export class NbPopoverDirective implements NbDynamicOverlayController, OnChanges
  return this._adjustment;
  }
  set adjustment(value: NbAdjustment) {
- if (!value) {
- // @breaking-change Remove @5.0.0
- console.warn(`Falsy values for 'nbPopoverAdjustment' are deprecated and will be removed in Nebular 5.
- Use 'noop' instead.`);
- value = NbAdjustment.NOOP;
- }
  this._adjustment = value;
  }
  protected _adjustment: NbAdjustment = NbAdjustment.CLOCKWISE;

diff --git a/src/framework/theme/components/tooltip/tooltip.directive.ts b/src/framework/theme/components/tooltip/tooltip.directive.ts
@@ -104,12 +104,6 @@ export class NbTooltipDirective implements OnInit, OnChanges, AfterViewInit, OnD
  return this._adjustment;
  }
  set adjustment(value: NbAdjustment) {
- if (!value) {
- // @breaking-change Remove @5.0.0
- console.warn(`Falsy values for 'nbPopoverAdjustment' are deprecated and will be removed in Nebular 5.
- Use 'noop' instead.`);
- value = NbAdjustment.NOOP;
- }
  this._adjustment = value;
  }
  protected _adjustment: NbAdjustment = NbAdjustment.CLOCKWISE;