Fix for #233: TryGetObject threws. #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,6 +42,7 @@ protected Config() | |||
| protected Config(HoconValue value) | |||
| { | |||
| Value = (HoconValue)value.Clone(null); | |||
| Root = (HoconValue)value.Clone(null); | |||
There was a problem hiding this comment.
No, they're different instances, the original value is cloned twice, one to the Value property, the second is into the Root property.
There was a problem hiding this comment.
but at this point of the code, they are Equal, but not ReferenceEqual
| @@ -90,25 +93,7 @@ public Config(HoconRoot root, Config fallback) : this(root) | |||
| /// </summary> | |||
| public virtual bool IsEmpty => Value == EmptyValue && _fallbacks.Count == 0; | |||
|
|
|||
| protected HoconValue _mergedValueCache = null; | |||
| public HoconValue Root | |||
|
|
||
| _mergedValueCache = null; | ||
| return result; | ||
| return new Config(this, fallback); |
This was referenced Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #233
Bug was caused by multiple threads accessing the
Config.Rootproperty andConfig.Rootwas not thread-safe.