Fix removing substitutions that are still to be resolved #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again, seeing the PR show up in the Azure DevOps queue but I'm not seeing the status on the Github PR itself. The main Akka.NET project doesn't have this problem 😠 |
Indeed, very weird... And I even do not have any link to check out CI results (but luckily in this repo CI results are usually the same as after running tests locally). |
Aaronontheweb
pushed a commit
that referenced
this pull request
Dec 27, 2019
* Added failing test * Fixed related test * Fixed removing of valid substitutions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #123
The problem here was that when setting value to some object's key, we were deleting all substitutions from the old value - even if the same substitutions were used in new value.
Also, noticed that rewriting value was used only for literals. I.e.
was failing, since it did not allow arrays to overwrite values. Which is of course a bug. Fixed as it was almost in the same line.