Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigurationFactory.Load should just call ConfigurationFactory.Default internally #189

Closed
Aaronontheweb opened this issue Jan 22, 2020 · 0 comments · Fixed by #201
Closed

ConfigurationFactory.Load should just call ConfigurationFactory.Default internally #189

Aaronontheweb opened this issue Jan 22, 2020 · 0 comments · Fixed by #201
Labels
akkadotnet-compat Legacy compatibility with Akka.Configuration
Milestone
1.3.2

Comments

@Aaronontheweb
Copy link
Member

Version: 1.3.1

As I discovered while working on akkadotnet/akka.net#4128, many of our old calls to ConfigurationFactory.Load now no longer function since we aren't using App.config inside our .NET Core applications. Therefore, we should just have it ConfigurationFactory.Load() call ConfigurationFactory.Default() internally in order to preserve behavior.
@Aaronontheweb Aaronontheweb added the akkadotnet-compat Legacy compatibility with Akka.Configuration label Jan 22, 2020
@Aaronontheweb Aaronontheweb added this to the 1.3.2 milestone Jan 22, 2020
Aaronontheweb added a commit to Aaronontheweb/HOCON that referenced this issue Jan 24, 2020
@Aaronontheweb
close akkadotnet#189 - make ConfigurationFactory.Load behavior backwa…
5bc6239 
…rds compatible
@Aaronontheweb Aaronontheweb mentioned this issue Jan 24, 2020
Merged
Aaronontheweb added a commit that referenced this issue Jan 24, 2020
@Aaronontheweb
close #189 - make ConfigurationFactory.Load behavior backwards compat…
2261470 
…ible (#201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
akkadotnet-compat Legacy compatibility with Akka.Configuration
Projects
None yet
Milestone
1.3.2
Development

Successfully merging a pull request may close this issue.

make ConfigurationFactory.Load behavior backwards compatible Aaronontheweb/HOCON
1 participant
@Aaronontheweb