Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Different shading factor for bright/dark theme #579

Closed
gmmyung opened this issue May 18, 2024 · 0 comments · Fixed by #580
Closed

[FEATURE] Different shading factor for bright/dark theme #579

gmmyung opened this issue May 18, 2024 · 0 comments · Fixed by #580

Comments

@gmmyung
Copy link
Contributor

gmmyung commented May 18, 2024

My Neovim setup changes its theme based on its OS dark mode setting.
The main problem is that toggleterm hardcodes the shading factor of light/dark background.

the percentage by which to lighten terminal background, default: -30 (gets multiplied by -3 if background is light)

image image

This results in bright mode background clipping to plain white, which isn't desired. It would be nice to separate those two shading factor, or changing the shading algorithm so that it doesn't clip into plain white.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant