-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] keymap focus / cursor desync with ToggleTermSendCurrentLine and ToggleTermSendVisualLines #457
Comments
@louis-vinchon the exact same comment I mentioned in the other issue applies here as well. This issues sounds quite strange though in a way that deviates from how neovim works at all tbh i.e. You can't really have focus in a different place from the cursor AFAIK. But in either case TLDR is PRs welcome but essentially I leave REPLish functionality to users willing to put in the work. It's either that or deprecating all of it to reduce this dimension of issues. |
map keys to lua ":lua vim.cmd [[ToggleTermSendVisualSelection ]] <cr>", I don't know why, but it works lazy.nvim config {
"akinsho/toggleterm.nvim",
cmd = {
"ToggleTermSendVisualSelection",
"ToggleTermSendCurrentLine",
},
keys = {
{ "<leader>tc", "<cmd>ToggleTermSendCurrentLine<cr>", desc = "Send Current Line" },
{
mode = { "v" },
"<leader>ts",
":lua vim.cmd [[ToggleTermSendVisualSelection ]] <cr>",
desc = "Send Selection Lines",
silent = true
},
}
} |
Is there an existing issue for this?
Current Behavior
When opening a terminal with:
ToggleTermSendCurrentLine
ToggleTermSendVisualLines
The terminal opens but:
Such as if I use
hjkl
my cursor moves inside the original window, but if I use a keymap that does"<cmd>q!<CR>"
it closes the terminal window.The above is what happens on the first iteration. On the second iteration, the terminal window opens, but the terminal buffer is inserted into my original "document" buffer window instead of its own.
Alternatively: when manually running
:q
The first iteration goes as expected: the terminal opens, my cursor is still in the window, I type
:q
, my original window closes.The second iteration however goes exactly as described above.
Expected Behavior
Repeated uses of the commands should open new terminal windows when needed, and the terminal windows should always go to those buffers.
It seems that even though the cursor doesn't switch windows, the keymap capture does, this should not happen.
Steps To Reproduce
Lazy lua module:
Sample line to execute:
Environment
$ uname -a Linux arch 6.4.1-arch2-1 #1 SMP PREEMPT_DYNAMIC Tue, 04 Jul 2023 08:39:40 +0000 x86_64 GNU/Linux
Anything else?
No response
The text was updated successfully, but these errors were encountered: