Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Multiple terminals open in a container tab #260

Open
fgsch opened this issue Jul 8, 2022 · 6 comments
Open

[Feature] Multiple terminals open in a container tab #260

fgsch opened this issue Jul 8, 2022 · 6 comments

Comments

@fgsch
Copy link

fgsch commented Jul 8, 2022

Hi.

Is there any reason why side-by-side is not supported for tabs? If not, can I turn this into a feature request? 馃槃
Thank you!

@akinsho
Copy link
Owner

akinsho commented Jul 8, 2022

@fgsch please add details when opening an issue you've only included a single line, I have no idea what this request is asking for, but it sounds like trying to emulate the UI of a GUI editor

@fgsch
Copy link
Author

fgsch commented Jul 8, 2022

@akinsho Sorry, let me clarify. The README says that opening multiple terminals side-by-side is not supported when the direction is tab. I was wondering if there is an underlying technical limitation or if this is something that could be implemented in the future. Thanks again.

@akinsho
Copy link
Owner

akinsho commented Jul 8, 2022

Hmm, it's not a technical limitation and could look nice, but I don't think it will be easy. How would it work if a user closed one of these tab splits, when they try to re-open it if they have to move to another tab with their normal buffer in it what should happen? Does the terminal stay locked to the containing tab or are they supposed to be reopened in any other tab if someone toggles them with the same ID

To be completely frank, there are many questions like this, and I'm definitely not looking to invest the time into it myself anytime soon. PRs welcome 馃檹馃徔

@fgsch
Copy link
Author

fgsch commented Jul 9, 2022

That's fair. Thank you for getting back to me. I will close this for now.

@fgsch fgsch closed this as completed Jul 9, 2022
@akinsho
Copy link
Owner

akinsho commented Jul 9, 2022

@fgsch I sort of like this idea tbh, that maybe you could open a tab and then have a bunch of terminals which are localized to that tab 馃. I'll keep this open a little while longer, if the idea tickle the back of my mind long enough I might try and implement it. Otherwise I'll close this out if I come back and don't think it'll work

@akinsho akinsho reopened this Jul 9, 2022
@akinsho akinsho changed the title [QUESTION] is it possible to support side-by-side tabs? [Feature] Multiple terminals open in a container tab Jul 9, 2022
@akinsho
Copy link
Owner

akinsho commented Jul 9, 2022

Note for a possible future self or contributor.

I'm thinking that each terminal could store a tab number in its state, not sure if this would work if nvim was closed and a session was restarted later, would the tab number change.

If a terminal has a tab number then it should act as hidden unless that tab is in view so that a user can't open a tab local terminal outside the host tab (they should just use a regular toggleterm for that, maybe down the line they can be detachable, but that's way too much complexity to start with)

You should be able to toggle the parent tab, which opens with all its children and handle child tabs within it, but all actions are localized to the tab that's a hard rule otherwise this will devolve into chaos since managing what goes where is already a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants