diff --git a/Applications/Browser/main.cpp b/Applications/Browser/main.cpp index 1ed5d03d3bd58e..0bf63bb9b4c22a 100644 --- a/Applications/Browser/main.cpp +++ b/Applications/Browser/main.cpp @@ -38,6 +38,7 @@ #include #include #include +#include #include #include #include @@ -104,8 +105,9 @@ int main(int argc, char** argv) bool bookmarksbar_enabled = true; - auto& toolbar = widget.add(); - auto& bookmarksbar = widget.add(bookmarks_filename, bookmarksbar_enabled); + auto& toolbar_container = widget.add(); + auto& toolbar = toolbar_container.add(); + auto& bookmarksbar = toolbar_container.add(bookmarks_filename, bookmarksbar_enabled); auto& html_widget = widget.add(); bookmarksbar.on_bookmark_click = [&](auto&, auto& url) { diff --git a/Applications/FileManager/main.cpp b/Applications/FileManager/main.cpp index e6e33d804b819d..0d3742934c8c00 100644 --- a/Applications/FileManager/main.cpp +++ b/Applications/FileManager/main.cpp @@ -52,6 +52,7 @@ #include #include #include +#include #include #include #include @@ -237,12 +238,14 @@ int run_in_windowed_mode(RefPtr config, String initial_locatio auto& widget = window->set_main_widget(); widget.set_layout(); - widget.layout()->set_spacing(0); + widget.set_fill_with_background_color(true); + widget.layout()->set_spacing(2); - auto& main_toolbar = widget.add(); - auto& location_toolbar = widget.add(); + auto& toolbar_container = widget.add(); + + auto& main_toolbar = toolbar_container.add(); + auto& location_toolbar = toolbar_container.add(); location_toolbar.layout()->set_margins({ 6, 3, 6, 3 }); - location_toolbar.set_preferred_size(0, 25); auto& location_label = location_toolbar.add("Location: "); location_label.size_to_fit(); diff --git a/Applications/Help/main.cpp b/Applications/Help/main.cpp index daf6819f65e3a9..44364cb37ddec1 100644 --- a/Applications/Help/main.cpp +++ b/Applications/Help/main.cpp @@ -38,6 +38,7 @@ #include #include #include +#include #include #include #include @@ -83,7 +84,8 @@ int main(int argc, char* argv[]) widget.set_layout(); widget.layout()->set_spacing(0); - auto& toolbar = widget.add(); + auto& toolbar_container = widget.add(); + auto& toolbar = toolbar_container.add(); auto& splitter = widget.add(); diff --git a/Applications/IRCClient/IRCAppWindow.cpp b/Applications/IRCClient/IRCAppWindow.cpp index 61d36415133b4c..cbb94670b863d9 100644 --- a/Applications/IRCClient/IRCAppWindow.cpp +++ b/Applications/IRCClient/IRCAppWindow.cpp @@ -39,6 +39,7 @@ #include #include #include +#include #include #include @@ -312,7 +313,8 @@ void IRCAppWindow::setup_widgets() widget.set_layout(); widget.layout()->set_spacing(0); - auto& toolbar = widget.add(); + auto& toolbar_container = widget.add(); + auto& toolbar = toolbar_container.add(); toolbar.set_has_frame(false); toolbar.add_action(*m_change_nick_action); toolbar.add_separator(); diff --git a/Applications/QuickShow/main.cpp b/Applications/QuickShow/main.cpp index a60421e3197636..dd234ee14eedc6 100644 --- a/Applications/QuickShow/main.cpp +++ b/Applications/QuickShow/main.cpp @@ -38,6 +38,7 @@ #include #include #include +#include #include #include #include @@ -71,7 +72,8 @@ int main(int argc, char** argv) root_widget.set_layout(); root_widget.layout()->set_spacing(0); - auto& main_toolbar = root_widget.add(); + auto& toolbar_container = root_widget.add(); + auto& main_toolbar = toolbar_container.add(); auto& widget = root_widget.add(); widget.on_scale_change = [&](int scale) { diff --git a/Applications/TextEditor/TextEditorWidget.cpp b/Applications/TextEditor/TextEditorWidget.cpp index 994b13f703c03b..afb27ea4416f43 100644 --- a/Applications/TextEditor/TextEditorWidget.cpp +++ b/Applications/TextEditor/TextEditorWidget.cpp @@ -46,15 +46,18 @@ #include #include #include +#include #include #include TextEditorWidget::TextEditorWidget() { + set_fill_with_background_color(true); set_layout(); - layout()->set_spacing(0); + layout()->set_spacing(2); - auto& toolbar = add(); + auto& toolbar_container = add(); + auto& toolbar = toolbar_container.add(); m_editor = add(); m_editor->set_ruler_visible(true); m_editor->set_automatic_indentation_enabled(true); diff --git a/DevTools/HackStudio/main.cpp b/DevTools/HackStudio/main.cpp index 372886a1612e66..b22bf4f90d5c3c 100644 --- a/DevTools/HackStudio/main.cpp +++ b/DevTools/HackStudio/main.cpp @@ -58,6 +58,7 @@ #include #include #include +#include #include #include #include @@ -163,7 +164,8 @@ int main(int argc, char** argv) open_project("/home/anon/js/javascript.files"); - auto& toolbar = widget.add(); + auto& toolbar_container = widget.add(); + auto& toolbar = toolbar_container.add(); auto selected_file_names = [&] { Vector files; diff --git a/Libraries/LibGUI/Makefile b/Libraries/LibGUI/Makefile index 5156a15a4a0882..00549493735cfb 100644 --- a/Libraries/LibGUI/Makefile +++ b/Libraries/LibGUI/Makefile @@ -65,6 +65,7 @@ OBJS = \ TextDocument.o \ TextEditor.o \ ToolBar.o \ + ToolBarContainer.o \ TreeView.o \ UndoStack.o \ Variant.o \ diff --git a/Libraries/LibGUI/StatusBar.cpp b/Libraries/LibGUI/StatusBar.cpp index 004f266e1e4649..94fec633aa75fa 100644 --- a/Libraries/LibGUI/StatusBar.cpp +++ b/Libraries/LibGUI/StatusBar.cpp @@ -39,7 +39,7 @@ StatusBar::StatusBar(int label_count) set_size_policy(SizePolicy::Fill, SizePolicy::Fixed); set_preferred_size(0, 20); set_layout(); - layout()->set_margins({ 0, 3, 0, 0 }); + layout()->set_margins({ 0, 0, 0, 0 }); layout()->set_spacing(2); if (label_count < 1) diff --git a/Libraries/LibGUI/ToolBar.cpp b/Libraries/LibGUI/ToolBar.cpp index 0c05f7b6935d1b..9ef8f7979c8f2b 100644 --- a/Libraries/LibGUI/ToolBar.cpp +++ b/Libraries/LibGUI/ToolBar.cpp @@ -39,10 +39,10 @@ ToolBar::ToolBar(Orientation orientation, int button_size) { if (orientation == Orientation::Horizontal) { set_size_policy(SizePolicy::Fill, SizePolicy::Fixed); - set_preferred_size(0, button_size + 10); + set_preferred_size(0, button_size + 8); } else { set_size_policy(SizePolicy::Fixed, SizePolicy::Fill); - set_preferred_size(button_size + 10, 0); + set_preferred_size(button_size + 8, 0); } set_layout(orientation); layout()->set_spacing(0); @@ -111,9 +111,9 @@ void ToolBar::paint_event(PaintEvent& event) Painter painter(*this); painter.add_clip_rect(event.rect()); - if (m_has_frame) - Gfx::StylePainter::paint_surface(painter, rect(), palette(), x() != 0, y() != 0); - else + //if (m_has_frame) +// Gfx::StylePainter::paint_surface(painter, rect(), palette(), x() != 0, y() != 0); +// else painter.fill_rect(event.rect(), palette().button()); } diff --git a/Libraries/LibGUI/ToolBarContainer.cpp b/Libraries/LibGUI/ToolBarContainer.cpp new file mode 100644 index 00000000000000..6d7bc8507c3136 --- /dev/null +++ b/Libraries/LibGUI/ToolBarContainer.cpp @@ -0,0 +1,86 @@ +/* + * Copyright (c) 2020, Andreas Kling + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * + * 2. Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER + * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#include +#include +#include +#include +#include + +namespace GUI { + +void ToolBarContainer::did_add_toolbar(Widget& toolbar) +{ + m_toolbars.append(toolbar); + int preferred_size = 4 + (m_toolbars.size() - 1) * 2; + + for (auto& toolbar : m_toolbars) { + if (m_orientation == Gfx::Orientation::Horizontal) + preferred_size += toolbar.preferred_size().height(); + else + preferred_size += toolbar.preferred_size().width(); + } + + if (m_orientation == Gfx::Orientation::Horizontal) + set_preferred_size(0, preferred_size); + else + set_preferred_size(preferred_size, 0); +} + +ToolBarContainer::ToolBarContainer(Gfx::Orientation orientation) + : m_orientation(orientation) +{ + set_fill_with_background_color(true); + + set_frame_thickness(2); + set_frame_shape(Gfx::FrameShape::Box); + set_frame_shadow(Gfx::FrameShadow::Sunken); + + if (m_orientation == Gfx::Orientation::Horizontal) + set_size_policy(SizePolicy::Fill, SizePolicy::Fixed); + else + set_size_policy(SizePolicy::Fixed, SizePolicy::Fill); + + auto& layout = set_layout(); + layout.set_spacing(2); + layout.set_margins({ 2, 2, 2, 2 }); +} + +void ToolBarContainer::paint_event(GUI::PaintEvent& event) +{ + Painter painter(*this); + painter.add_clip_rect(event.rect()); + + for (auto& toolbar : m_toolbars) { + auto rect = toolbar.relative_rect(); + painter.draw_line(rect.top_left().translated(0, -1), rect.top_right().translated(0, -1), palette().threed_highlight()); + painter.draw_line(rect.bottom_left().translated(0, 1), rect.bottom_right().translated(0, 1), palette().threed_shadow1()); + } + + Frame::paint_event(event); +} + +} diff --git a/Libraries/LibGUI/ToolBarContainer.h b/Libraries/LibGUI/ToolBarContainer.h new file mode 100644 index 00000000000000..4dcbf936769d4a --- /dev/null +++ b/Libraries/LibGUI/ToolBarContainer.h @@ -0,0 +1,58 @@ +/* + * Copyright (c) 2020, Andreas Kling + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * + * 2. Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER + * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#pragma once + +#include +#include + +namespace GUI { + +class ToolBarContainer : public Frame { + C_OBJECT(ToolBarContainer); + +public: + template + inline T& add(Args&&... args) + { + auto& child = Frame::add(forward(args)...); + did_add_toolbar(child); + return child; + } + +private: + explicit ToolBarContainer(Gfx::Orientation = Gfx::Orientation::Horizontal); + + virtual void paint_event(GUI::PaintEvent&) override; + + void did_add_toolbar(Widget&); + + Gfx::Orientation m_orientation { Gfx::Orientation::Horizontal }; + + NonnullRefPtrVector m_toolbars; +}; + +}