Fix number of sections being out of bounds crash #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryankeller
commented
Aug 3, 2022
| @@ -1,6 +1,6 @@ | |||
| Pod::Spec.new do |s| | |||
| s.name = 'MagazineLayout' | |||
| s.version = '1.6.9' | |||
There was a problem hiding this comment.
wish we could have stayed on this version longer 😞
brynbodayle
approved these changes
Aug 3, 2022
bryankeller
commented
Aug 3, 2022
Comment on lines
+33
to
+41
| public override var debugDescription: String { | ||
| "Invalidate: everything - \(invalidateEverything), " + | ||
| "data source counts - \(invalidateDataSourceCounts), " + | ||
| "offset adjustment - \(contentOffsetAdjustment), " + | ||
| "size adjustment - \(contentSizeAdjustment), " + | ||
| "item index paths - \(String(describing: invalidatedItemIndexPaths)), " + | ||
| "supplementary index paths - \(String(describing: invalidatedSupplementaryIndexPaths)), " + | ||
| "decoration index paths - \(String(describing: invalidatedDecorationIndexPaths))" | ||
| } |
There was a problem hiding this comment.
this was useful so just going to leave it in so I don't have to keep re-adding it locally
bryankeller
commented
Aug 3, 2022
Comment on lines
-382
to
-383
| // Returning `nil` rather than default/frameless layout attributes causes internal exceptions | ||
| // within `UICollectionView`, which is why we don't return `nil` here. |
There was a problem hiding this comment.
I wasn't able to repro this internal exception, and we return nil in other places, so seems ok to return nil
|
Also, I used my separate app to slam this with randomized batch updates - no crashes or assertions 🥳 |
This was referenced Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
layoutAttributesForItemAt:can be invoked with an out-of-bounds index path. Previous comments in code seem to indicate that this is not a new issue.I believe the root of all of these issues is that the layout can be invalidated in between when the data source counts change (from a batch update), and when the layout actually receives an invalidate context specifying that data source counts have changed. This behavior sucks, and I don't see a clear way to work around this. This is something that I chatted about with a UICollectionView engineer back in 2019, and that person made it sound like they were using some private APIs in the layout to work around this 😩
Related Issue
N/A
Motivation and Context
Crash / assertion "fix" / workaround
How Has This Been Tested
Example project
Types of changes
Checklist