Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headers to ClientSession.ws_connect. #785

Closed
Rapptz opened this issue Feb 16, 2016 · 5 comments
Closed

Add headers to ClientSession.ws_connect. #785

Rapptz opened this issue Feb 16, 2016 · 5 comments
Labels
outdated sprint
Milestone
0.22

Comments

@Rapptz
Copy link

Rapptz commented Feb 16, 2016

The documentation says bare aiohttp.ws_connect is deprecated and ClientSession.ws_connect should be used instead.

However, the latter has less features than the former. ClientSession.ws_connect does not have the headers keyword argument to allow us to add any headers we want while aiohttp.ws_connect does.
@asvetlov
Copy link
Member

Does session headers satisfy your requirements or do you need temporary headers specific to ws_connect request?

@Rapptz
Copy link
Author

Rapptz commented Feb 16, 2016

The latter. Some headers can be global, e.g. I set the content type in the Session headers but the ws_connect does not need them.

@asvetlov
Copy link
Member

That makes sense. Would you provide a Pull Request?

@asvetlov asvetlov added this to the 0.22 milestone Feb 16, 2016
@asvetlov asvetlov added the sprint label Jun 2, 2016
vaskalas added a commit to vaskalas/aiohttp that referenced this issue Jun 2, 2016
@vaskalas
added headers to ClientSession.ws_connnect aio-libs#785
f1410df
asvetlov added a commit that referenced this issue Jun 3, 2016
@asvetlov
Merge pull request #898 from vaskalas/master
4b79ec3 
added headers to ClientSession.ws_connnect #785
@asvetlov asvetlov mentioned this issue Jun 3, 2016
Merged
3 tasks
@asvetlov
Copy link
Member

asvetlov commented Jun 3, 2016

Fixed by #898

@asvetlov asvetlov closed this as completed Jun 3, 2016
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated sprint
Projects
None yet
Milestone
0.22
Development

No branches or pull requests
2 participants
@asvetlov @Rapptz