Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy authentication when connecting to https host does not working #617

Closed
ssbb opened this issue Nov 3, 2015 · 7 comments
Closed

Proxy authentication when connecting to https host does not working #617

ssbb opened this issue Nov 3, 2015 · 7 comments
Labels

Comments

@ssbb
Copy link
Contributor

ssbb commented Nov 3, 2015

Hi!

I have my own proxy server which support both HTTP/HTTPS with authentication and works fine with requests/urllib.request. But with aiohttp ProxyConnector I got 407 error when trying to load HTTPS page via GET request (everything is okay with HTTP).

@ssbb
Copy link
Contributor Author

ssbb commented Nov 3, 2015

Why it can happens and maybe I can tune my proxy servers (TOR + Polipo + HAProxy) for make it work? Thanks :)

@ssbb
Copy link
Contributor Author

ssbb commented Nov 3, 2015

@asvetlov It works for me with this change: https://github.com/ssbb/aiohttp/blob/master/aiohttp/connector.py#L660 (sorry, just have few typo commits, so it will be easy to read just code instead of commit).

But I am not sure if it's a right solution. Can someone confirm?

@ssbb
Copy link
Contributor Author

ssbb commented Nov 3, 2015

Also I got this warning for each opened connection when using ssl proxies:

Unclosed response client_response: <ClientResponse(https://********/) [200 Tunnel established]> <_CIMultiDictProxy()>

@asvetlov
Copy link
Member

asvetlov commented Nov 3, 2015

Hi. I have notification about broken ssl proxy from private source.
Will check your patch soon.

@Eijebong
Copy link

Same problem here.

asvetlov added a commit that referenced this issue Dec 5, 2015
@asvetlov
Copy link
Member

asvetlov commented Dec 5, 2015

Fixed

@asvetlov asvetlov closed this as completed Dec 5, 2015
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants