Handling WebSocket disconnects

[saghul]

When reading from a ws connection, the receive_msg function may raise WSClientDisconnectedError. The example in the documentation just returns the ws object once done:

@asyncio.coroutine
def websocket_handler(request):
    ws = web.WebSocketResponse()
    ws.start(request)

    while True:
        try:
            data = yield from ws.receive_str()
            ws.send_str(data)
        except web.WSClientDisconnectedError:
            return ws

However, when an error is produced the exception is also stored in the closing_fut: https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/web.py#L833-L859 As a result, a warning is logged because nobody retrieves that exception. I guess one way to "solve" it is to do something like this:

@asyncio.coroutine
def websocket_handler(request):
    ws = web.WebSocketResponse()
    ws.start(request)

    while True:
        try:
            data = yield from ws.receive_str()
            ws.send_str(data)
        except web.WSClientDisconnectedError:
            try:
                yield from ws.wait_closed()
            except web.WSClientDisconnectedError:
                pass
            return ws

But it kinda feels wrong.

Am I missing something or should this be handled differently? Thanks a lot for aiohttp, I'm really liking it so far!

[asvetlov]

Got it, my wrong. Thanks for report, I'll publish 0.14.2 patch very shortly.

[fafhrd91]

@asvetlov wait with release

[fafhrd91]

should be fixed

[saghul]

Thanks, I'll give it a shot. I see you added wait_eof in c587340, is that supposed to be used after getting the error while reading or will it be used internally?

[fafhrd91]

RequestHandler always calls response.write_eof() and ServerHttpProtocol should handle WSClientDisconnectedError exception properly.

[saghul]

Thanks for clarifying!

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.