Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception on _pong_not_received for websockets #1793

Closed
NotSqrt opened this issue Apr 6, 2017 · 2 comments
Closed

Exception on _pong_not_received for websockets #1793

NotSqrt opened this issue Apr 6, 2017 · 2 comments
Labels
Milestone

Comments

@NotSqrt
Copy link
Contributor

NotSqrt commented Apr 6, 2017

Long story short

Hi!
An exception occurs when closing the websocket connection in _pong_not_received if the connection was already dropped somehow :

  File "aiohttp/web_ws.py", line 88, in _pong_not_received
    self._req.transport.close()
AttributeError: 'NoneType' object has no attribute 'close'

Expected behaviour

No exception.

Actual behaviour

self._req is not None, but self._req.transport is None.

Your environment

Python 3.5, aiohttp==2.0.5, standard loop, server behind nginx.

The issue is happening with really bad websocket clients, not web browsers, that may drop connections without sending close control frames.

Thanks !

@fafhrd91 fafhrd91 added this to the 2.1 milestone Apr 8, 2017
@fafhrd91
Copy link
Member

fafhrd91 commented Apr 8, 2017

should be fixed in master

fafhrd91 added a commit that referenced this issue Apr 12, 2017
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants