Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request.post() ignores blank values #1765

Closed
Dexus77 opened this issue Mar 28, 2017 · 6 comments
Closed

request.post() ignores blank values #1765

Dexus77 opened this issue Mar 28, 2017 · 6 comments
Labels

Comments

@Dexus77
Copy link

Dexus77 commented Mar 28, 2017

Long story short

This is an old problem, which was previously fixed, returned again.

web_request.py

out.extend( parse_qsl( data.rstrip().decode(charset), encoding=charset))
out.extend( parse_qsl( data.rstrip().decode(charset), encoding=charset, keep_blank_values=True))

Expected behaviour

Actual behaviour

Steps to reproduce

Your environment

fafhrd91 added a commit that referenced this issue Apr 4, 2017
keep blank values while parsing form (#1765)
@fafhrd91
Copy link
Member

fafhrd91 commented Apr 4, 2017

should be fixed

@fafhrd91 fafhrd91 closed this as completed Apr 4, 2017
@iceboy233
Copy link
Member

I also notice another usage of parse_qsl in aiohttp/multipart.py. Should we also fix that as well (or is it intended to remove blank values)?

@fafhrd91
Copy link
Member

fafhrd91 commented Apr 5, 2017

@kxepal could you check?

@kxepal
Copy link
Member

kxepal commented Apr 5, 2017

@iceb0y
I think we can apply the same fix for multipart as well. No intentions were there againt that. Would you like to make another patch for that?

@iceboy233
Copy link
Member

thanks, will do sometime

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants