Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with asyncio 3.4.1+ #170

Closed
asvetlov opened this issue Oct 30, 2014 · 5 comments
Closed

Fix compatibility with asyncio 3.4.1+ #170

asvetlov opened this issue Oct 30, 2014 · 5 comments
Labels

Comments

@asvetlov
Copy link
Member

In new asyncio StreamWriter.drain has become coroutine instead of plain function.
That means that transport.drain() should be un-yielded.

Drawback is: in debug mode (PYTHONASYNCIODEBUG env var is on) CoroWrapper raises exception.

Will fix quickly and publish 0.9.3 release.
Need to setup travis for passing tests both with PYTHONASYNCIODEBUG and without it.

@asvetlov
Copy link
Member Author

Fixed in 0.9.3

@fafhrd91
Copy link
Member

I think we should stop using streams.py from asyncio.

@asvetlov
Copy link
Member Author

@fafhrd91 maybe you are true but I'm not ready to drop streams right now.

@ludovic-gasc
Copy link
Contributor

FYI, during PyCON-FR, I've discussed with some AsyncIO developers.
They asked me why in aiohttp the streams have been redefined.
Personally, I've no idea about the reason.

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants