-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.10 #5927
Conversation
This comment has been minimized.
This comment has been minimized.
350ae84
to
5d9a210
Compare
pycares is not ready for Python 3.10. See the action log https://github.com/aio-libs/aiohttp/pull/5927/checks?check_run_id=3223285551 and upstream issue saghul/pycares#134 |
Indeed, we can fix the deprecation warnings in another PR in the meantime though. |
5d9a210
to
fa3f100
Compare
Hey @Hanaasagi, |
fa3f100
to
539e6e3
Compare
I rebased the master branch. But I don't figure out why there are two failed test.
Looks like they were introduced in PR #5992 . About the changesDependency update
Fixing warnings
|
Yep. And they weren't tested against Python 3.10. Here's what's happening in the CI: E ConnectionAbortedError: SSL handshake is taking longer than 60.0 seconds: aborting the connection I wonder if this is caused by proxy.py not supporting Python 3.10 or something on our side... Any ideas? I think it may be okay to temporarily mark the specific test cases with |
for more information, see https://pre-commit.ci
The secure proxy related test will be passed in 3.10, macos, but failed in other os platform. I marked them with xfail. |
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 84babeb on top of patchback/backports/3.8/84babebc96e08f1ea2b7c31406eb5a1ed20cd5c4/pr-5927 Backporting merged PR #5927 into master
🤖 @patchback |
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 84babeb on top of patchback/backports/3.8/84babebc96e08f1ea2b7c31406eb5a1ed20cd5c4/pr-5927 Backporting merged PR #5927 into master
🤖 @patchback |
Co-authored-by: Sviatoslav Sydorenko <[email protected]> (cherry picked from commit 84babeb)
Co-authored-by: Sviatoslav Sydorenko <[email protected]> (cherry picked from commit 84babeb) Co-authored-by: 秋葉 <[email protected]>
@Hanaasagi Do you think it's worth readding the experimental matrix back in for 3.11? I see there is already an alpha release available, so would be good to have an early warning of any issues this time. https://github.com/actions/python-versions/releases |
IFAIK cython for py3.11 is broken; we just cannot compile aiohttp extensions. |
If it's just cython though, then we would still get something useful from the no_extensions tests. We can also just leave the cython tests in, so they should start running successfully at some point in the future. |
@Dreamsorcerer feel free to add a limited matrix extension to cover this but we probably don't need it for the v3.8 release so it can wait. |
What do these changes do?
Add Python 3.10 matrix in Github Action and fix something.
Are there changes in behavior for the user?
Related issue number
Related to #5905
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.