secure_proxy_ssl_header with gunicorn

[samuelcolvin]

Long story short

I think it's not possible to set secure_proxy_ssl_header when deploying with gunicorn.

Expected behaviour

gunicorn config or environment variable should allow me to set secure_proxy_ssl_header='X-Forwarded-Proto' so request.scheme is correct.

Actual behaviour

No apparent way to set it.

Steps to reproduce

Can give more detail if required.

Your environment

Heroku, but should be the same with any other.

[samuelcolvin]

currently i'm using

secure = 'https' in (request.scheme, request.headers.get('X-Forwarded-Proto'))
ws_scheme = 'wss' if secure else 'ws'
ws_url = f'{ws_scheme}:https://{request.host}/ws'

In addition to fixing secure_proxy_ssl_header it would be great if there was request.secure: bool to avoid the need for == 'https' etc.

[fafhrd91]

do you want to work on this?

[samuelcolvin]

Can do, just a key word argument to Application should work.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.