Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize signals #86

Closed
johanos1 opened this issue Jul 2, 2024 · 0 comments · Fixed by #94
Closed

Generalize signals #86

johanos1 opened this issue Jul 2, 2024 · 0 comments · Fixed by #94
Labels
bug Something isn't working enhancement New feature or request

Comments

@johanos1
Copy link
Collaborator

johanos1 commented Jul 2, 2024

Issue

Problem Description

The signal.py file assumes that data can be represented as a numpy array. This is not true for all use-cases and we should generalize this to accept an index and the handler instead to fetch the data.

Expected Behavior

Ability to evaluate signals for arbitrary datasets.

What Needs to be Done

Update all the functions in signal.py to accept handler and indices.

How Can It Be Tested or Reproduced

Run attacks.

@johanos1 johanos1 added bug Something isn't working enhancement New feature or request labels Jul 2, 2024
@johanos1 johanos1 mentioned this issue Jul 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant