{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":349474412,"defaultBranch":"main","name":"sapling","ownerLogin":"ahornby","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-03-19T15:43:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/14246801?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1717888942.0","currentOid":""},"activityList":{"items":[{"before":"cdafad8db5ecddaba9fe0494b6559c695cda44ae","after":"0828ea99905ec89c1269d90339977c57813993e9","ref":"refs/heads/main","pushedAt":"2024-07-16T10:25:23.000Z","pushType":"push","commitsCount":576,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix Windows subprocess creation\n\nSummary:\n# Context\n\nOn Windows, process creation was consistently failing with the following error:\n\n```\nclass std::system_error: CreateProcess(\"C:\\tools\\eden\\libexec\\edenfsctl.exe\" \"--etc-eden-dir\" \"C:\\ProgramData\\facebook\\eden\" \"redirect\" \"fixup\" \"--mount\" \"C:\\open\\fbsource\") failed with err code: 87\n```\n\nWhere error code 87 means \"The parameters are incorrect\"\n\nIt was unclear why this was happening. After hours of debugging, I've found that you can fix the problem by setting the stdin, stderr, and stdout of the subprocess to null. Something must be wrong with the way we handle inherriting default values for stdin/stderr, but the root cause is not entirely clear.\n\nWhile I still don't fully understand the reason CreateProcess fails, it feels like this fix is safe enough to deploy for now.\n\n# This diff\n\nThis diff sets the stderr, stdin, and stdout handles to null on Windows. It also ensures that a window is not created for the subprocess.\n\nReviewed By: quark-zju\n\nDifferential Revision: D59783277\n\nfbshipit-source-id: cfed9a190b6dc8e9a643b23f84653b3780a1d87b","shortMessageHtmlLink":"fix Windows subprocess creation"}},{"before":"868e9499db9f291ee1cc674c1bf8730cd888b2f2","after":"cdafad8db5ecddaba9fe0494b6559c695cda44ae","ref":"refs/heads/main","pushedAt":"2024-06-16T21:49:34.000Z","pushType":"push","commitsCount":144,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/4f48b5a337cf60fd59feabfc46052a9e4bdc219f\nhttps://github.com/facebook/fb303/commit/3b8ca1794a6d387ac84026fe4885b9f7350b61f1\nhttps://github.com/facebook/fbthrift/commit/6ec2024fb98174f218d20df9054f345307f6ec20\nhttps://github.com/facebook/folly/commit/7e04ec74decce5cf59127c455056296c131d4c07\nhttps://github.com/facebook/mvfst/commit/21e05ab699d2ff374b2fd179a9fa403cbec3d5ea\nhttps://github.com/facebook/proxygen/commit/e59aa6487fb4ee791bd39fe5fc9f0b5d4b5cb1e7\nhttps://github.com/facebook/wangle/commit/754ecd758316e2731bf68850807f137badb077da\nhttps://github.com/facebookexperimental/edencommon/commit/b1adca0fd87ac5920bc62d083f03118944139333\nhttps://github.com/facebookexperimental/rust-shed/commit/4f83cc152b60ac2cb439539fd6aee1915de0114d\nhttps://github.com/facebookincubator/fizz/commit/98d56fdd9e27f6f4ea9e7b485770f7fdcffcb60e\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: 6be82441902714f7a2553d9e7cb996244ff3b68f","shortMessageHtmlLink":"Updating submodules"}},{"before":"b97fa7f2f59f20ea0439c8daf87e20109ab9da09","after":"08b45b07d3818c2f5c54afdb3bbeebb8db9d27d0","ref":"refs/heads/reviewstack.dev-prod","pushedAt":"2024-06-10T00:20:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 868e9499db9f291ee1cc674c1bf8730cd888b2f2","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/ahornby/sapling/commit/868e9499db9f291ee1cc674c1bf8730cd888b2f2/hovercard\" href=\"https://github.com/ahornby/sapling/commit/868e9499db9f291ee1cc674c1bf8730cd888b2f2\"><tt>868e949</tt></a>"}},{"before":"7a5036227a2461701964e7b7f6ace6e4e2046db1","after":"14ad9282a1cb397e34b906663abd30d35789d01b","ref":"refs/heads/sapling-pr-archive-ahornby","pushedAt":"2024-06-08T23:22:25.000Z","pushType":"push","commitsCount":2675,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Merge 9717e20a48a8b436e805e52fa3e59807bd073549 into sapling-pr-archive-ahornby","shortMessageHtmlLink":"Merge <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/ahornby/sapling/commit/9717e20a48a8b436e805e52fa3e59807bd073549/hovercard\" href=\"https://github.com/ahornby/sapling/commit/9717e20a48a8b436e805e52fa3e59807bd073549\"><tt>9717e20</tt></a> into sapling-pr-archive-ahornby"}},{"before":null,"after":"9717e20a48a8b436e805e52fa3e59807bd073549","ref":"refs/heads/pr903","pushedAt":"2024-06-08T23:22:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix eden cmake missing eden/common/utils/DirType.h\n\nSummary:\nfix missing header errors due to edencommon not in target link libraries\n\nTest Plan:\n\nRun local cmake build with: `./build/fbcode_builder/getdeps.py --allow-system-packages build eden`\n\nBefore, broken:\n```\n[12/387] Building CXX object eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o\nFAILED: eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o\n/usr/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DFOLLY_XLOG_STRIP_PREFIXES=\\\"/home/alex/local/sapling:/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden\\\" -DGFLAGS_IS_A_DLL=0 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden -I/home/alex/local/sapling -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fb303/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fizz/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/wangle/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fbthrift/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/googletest-VdBlGUPMPJitek6Vixf2wJ0d-fkcsAem4x561Ipyl_c/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/lmdb-EeqttKQ21Ssy0Z9v9Td5arfjclo9sZwEycvDeQZ707Q/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/gflags-4vXpjWHz7iQ-flj45DrshPtdnV00lhHzdluegsKfQv8/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/glog-rc1q5fRnLVjdS68JV9erzuj0hzjLqATGYHhZAKGSWHo/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/folly/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/boost-v767l9QNa5ozbwDxCGIOiS4txj6QsxfvDdR4F7KRbYY/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/zlib-I9YVwQvp3FsdWhYv3JD35W5331pwpP-NLFKrJNd9ubU/include -isystem /usr/include/libdwarf-0 -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fmt-XC7kuS1-TdG_KzAiD4Q16Eb-s6mNRaeEz1OrK4d5f7c/include -g -Wall -Wextra -Wno-deprecated -Wno-deprecated-declarations -Wno-unknown-pragmas -O2 -g -DNDEBUG -std=gnu++17 -MD -MT eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o -MF eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o.d -o eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o -c /home/alex/local/sapling/eden/fs/nfs/NfsUtils.cpp\nIn file included from /home/alex/local/sapling/eden/fs/nfs/NfsUtils.cpp:8:\n/home/alex/local/sapling/eden/fs/nfs/NfsUtils.h:13:10: fatal error: eden/common/utils/DirType.h: No such file or directory\n   13 | #include \"eden/common/utils/DirType.h\"\n      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\ncompilation terminated.\n[13/387] Building CXX object eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o\nFAILED: eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o\n/usr/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DFOLLY_XLOG_STRIP_PREFIXES=\\\"/home/alex/local/sapling:/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden\\\" -DGFLAGS_IS_A_DLL=0 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden -I/home/alex/local/sapling -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fb303/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fizz/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/wangle/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fbthrift/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/lmdb-EeqttKQ21Ssy0Z9v9Td5arfjclo9sZwEycvDeQZ707Q/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/gflags-4vXpjWHz7iQ-flj45DrshPtdnV00lhHzdluegsKfQv8/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/glog-rc1q5fRnLVjdS68JV9erzuj0hzjLqATGYHhZAKGSWHo/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/folly/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/googletest-VdBlGUPMPJitek6Vixf2wJ0d-fkcsAem4x561Ipyl_c/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/boost-v767l9QNa5ozbwDxCGIOiS4txj6QsxfvDdR4F7KRbYY/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/zlib-I9YVwQvp3FsdWhYv3JD35W5331pwpP-NLFKrJNd9ubU/include -isystem /usr/include/libdwarf-0 -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fmt-XC7kuS1-TdG_KzAiD4Q16Eb-s6mNRaeEz1OrK4d5f7c/include -g -Wall -Wextra -Wno-deprecated -Wno-deprecated-declarations -Wno-unknown-pragmas -O2 -g -DNDEBUG -std=gnu++17 -MD -MT eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o -MF eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o.d -o eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o -c /home/alex/local/sapling/eden/fs/nfs/test/AccessTest.cpp\nIn file included from /home/alex/local/sapling/eden/fs/nfs/test/AccessTest.cpp:14:\n/home/alex/local/sapling/eden/fs/nfs/NfsUtils.h:13:10: fatal error: eden/common/utils/DirType.h: No such file or directory\n   13 | #include \"eden/common/utils/DirType.h\"\n      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n```\n\nAfter, works","shortMessageHtmlLink":"fix eden cmake missing eden/common/utils/DirType.h"}},{"before":"ef2827f11a9a2fbf644fbda5cfb97e1d8744c16e","after":"9717e20a48a8b436e805e52fa3e59807bd073549","ref":"refs/heads/fix_eden_oss","pushedAt":"2024-06-08T18:00:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix eden cmake missing eden/common/utils/DirType.h\n\nSummary:\nfix missing header errors due to edencommon not in target link libraries\n\nTest Plan:\n\nRun local cmake build with: `./build/fbcode_builder/getdeps.py --allow-system-packages build eden`\n\nBefore, broken:\n```\n[12/387] Building CXX object eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o\nFAILED: eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o\n/usr/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DFOLLY_XLOG_STRIP_PREFIXES=\\\"/home/alex/local/sapling:/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden\\\" -DGFLAGS_IS_A_DLL=0 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden -I/home/alex/local/sapling -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fb303/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fizz/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/wangle/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fbthrift/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/googletest-VdBlGUPMPJitek6Vixf2wJ0d-fkcsAem4x561Ipyl_c/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/lmdb-EeqttKQ21Ssy0Z9v9Td5arfjclo9sZwEycvDeQZ707Q/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/gflags-4vXpjWHz7iQ-flj45DrshPtdnV00lhHzdluegsKfQv8/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/glog-rc1q5fRnLVjdS68JV9erzuj0hzjLqATGYHhZAKGSWHo/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/folly/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/boost-v767l9QNa5ozbwDxCGIOiS4txj6QsxfvDdR4F7KRbYY/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/zlib-I9YVwQvp3FsdWhYv3JD35W5331pwpP-NLFKrJNd9ubU/include -isystem /usr/include/libdwarf-0 -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fmt-XC7kuS1-TdG_KzAiD4Q16Eb-s6mNRaeEz1OrK4d5f7c/include -g -Wall -Wextra -Wno-deprecated -Wno-deprecated-declarations -Wno-unknown-pragmas -O2 -g -DNDEBUG -std=gnu++17 -MD -MT eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o -MF eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o.d -o eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o -c /home/alex/local/sapling/eden/fs/nfs/NfsUtils.cpp\nIn file included from /home/alex/local/sapling/eden/fs/nfs/NfsUtils.cpp:8:\n/home/alex/local/sapling/eden/fs/nfs/NfsUtils.h:13:10: fatal error: eden/common/utils/DirType.h: No such file or directory\n   13 | #include \"eden/common/utils/DirType.h\"\n      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\ncompilation terminated.\n[13/387] Building CXX object eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o\nFAILED: eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o\n/usr/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DFOLLY_XLOG_STRIP_PREFIXES=\\\"/home/alex/local/sapling:/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden\\\" -DGFLAGS_IS_A_DLL=0 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden -I/home/alex/local/sapling -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fb303/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fizz/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/wangle/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fbthrift/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/lmdb-EeqttKQ21Ssy0Z9v9Td5arfjclo9sZwEycvDeQZ707Q/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/gflags-4vXpjWHz7iQ-flj45DrshPtdnV00lhHzdluegsKfQv8/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/glog-rc1q5fRnLVjdS68JV9erzuj0hzjLqATGYHhZAKGSWHo/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/folly/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/googletest-VdBlGUPMPJitek6Vixf2wJ0d-fkcsAem4x561Ipyl_c/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/boost-v767l9QNa5ozbwDxCGIOiS4txj6QsxfvDdR4F7KRbYY/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/zlib-I9YVwQvp3FsdWhYv3JD35W5331pwpP-NLFKrJNd9ubU/include -isystem /usr/include/libdwarf-0 -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fmt-XC7kuS1-TdG_KzAiD4Q16Eb-s6mNRaeEz1OrK4d5f7c/include -g -Wall -Wextra -Wno-deprecated -Wno-deprecated-declarations -Wno-unknown-pragmas -O2 -g -DNDEBUG -std=gnu++17 -MD -MT eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o -MF eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o.d -o eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o -c /home/alex/local/sapling/eden/fs/nfs/test/AccessTest.cpp\nIn file included from /home/alex/local/sapling/eden/fs/nfs/test/AccessTest.cpp:14:\n/home/alex/local/sapling/eden/fs/nfs/NfsUtils.h:13:10: fatal error: eden/common/utils/DirType.h: No such file or directory\n   13 | #include \"eden/common/utils/DirType.h\"\n      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n```\n\nAfter, works","shortMessageHtmlLink":"fix eden cmake missing eden/common/utils/DirType.h"}},{"before":"fb37e9153b1711d71f689eb56d6c67e191f854fb","after":"ef2827f11a9a2fbf644fbda5cfb97e1d8744c16e","ref":"refs/heads/fix_eden_oss","pushedAt":"2024-06-08T14:33:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix eden cmake missing eden/common/utils/DirType.h\n\nSummary:\nfix missing header errors due to edencommon not in target link libraries\n\nTest Plan:\n\nRun local cmake build with: `./build/fbcode_builder/getdeps.py --allow-system-packages build eden`\n\nBefore, broken:\n```\n[12/387] Building CXX object eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o\nFAILED: eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o\n/usr/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DFOLLY_XLOG_STRIP_PREFIXES=\\\"/home/alex/local/sapling:/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden\\\" -DGFLAGS_IS_A_DLL=0 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden -I/home/alex/local/sapling -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fb303/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fizz/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/wangle/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fbthrift/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/googletest-VdBlGUPMPJitek6Vixf2wJ0d-fkcsAem4x561Ipyl_c/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/lmdb-EeqttKQ21Ssy0Z9v9Td5arfjclo9sZwEycvDeQZ707Q/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/gflags-4vXpjWHz7iQ-flj45DrshPtdnV00lhHzdluegsKfQv8/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/glog-rc1q5fRnLVjdS68JV9erzuj0hzjLqATGYHhZAKGSWHo/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/folly/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/boost-v767l9QNa5ozbwDxCGIOiS4txj6QsxfvDdR4F7KRbYY/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/zlib-I9YVwQvp3FsdWhYv3JD35W5331pwpP-NLFKrJNd9ubU/include -isystem /usr/include/libdwarf-0 -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fmt-XC7kuS1-TdG_KzAiD4Q16Eb-s6mNRaeEz1OrK4d5f7c/include -g -Wall -Wextra -Wno-deprecated -Wno-deprecated-declarations -Wno-unknown-pragmas -O2 -g -DNDEBUG -std=gnu++17 -MD -MT eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o -MF eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o.d -o eden/fs/nfs/CMakeFiles/eden_nfs_utils.dir/NfsUtils.cpp.o -c /home/alex/local/sapling/eden/fs/nfs/NfsUtils.cpp\nIn file included from /home/alex/local/sapling/eden/fs/nfs/NfsUtils.cpp:8:\n/home/alex/local/sapling/eden/fs/nfs/NfsUtils.h:13:10: fatal error: eden/common/utils/DirType.h: No such file or directory\n   13 | #include \"eden/common/utils/DirType.h\"\n      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\ncompilation terminated.\n[13/387] Building CXX object eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o\nFAILED: eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o\n/usr/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DFOLLY_XLOG_STRIP_PREFIXES=\\\"/home/alex/local/sapling:/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden\\\" -DGFLAGS_IS_A_DLL=0 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden -I/home/alex/local/sapling -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fb303/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fizz/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/wangle/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fbthrift/include -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/lmdb-EeqttKQ21Ssy0Z9v9Td5arfjclo9sZwEycvDeQZ707Q/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/gflags-4vXpjWHz7iQ-flj45DrshPtdnV00lhHzdluegsKfQv8/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/glog-rc1q5fRnLVjdS68JV9erzuj0hzjLqATGYHhZAKGSWHo/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/folly/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/googletest-VdBlGUPMPJitek6Vixf2wJ0d-fkcsAem4x561Ipyl_c/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/boost-v767l9QNa5ozbwDxCGIOiS4txj6QsxfvDdR4F7KRbYY/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/zlib-I9YVwQvp3FsdWhYv3JD35W5331pwpP-NLFKrJNd9ubU/include -isystem /usr/include/libdwarf-0 -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/installed/fmt-XC7kuS1-TdG_KzAiD4Q16Eb-s6mNRaeEz1OrK4d5f7c/include -g -Wall -Wextra -Wno-deprecated -Wno-deprecated-declarations -Wno-unknown-pragmas -O2 -g -DNDEBUG -std=gnu++17 -MD -MT eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o -MF eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o.d -o eden/fs/nfs/test/CMakeFiles/eden_nfs_test.dir/AccessTest.cpp.o -c /home/alex/local/sapling/eden/fs/nfs/test/AccessTest.cpp\nIn file included from /home/alex/local/sapling/eden/fs/nfs/test/AccessTest.cpp:14:\n/home/alex/local/sapling/eden/fs/nfs/NfsUtils.h:13:10: fatal error: eden/common/utils/DirType.h: No such file or directory\n   13 | #include \"eden/common/utils/DirType.h\"\n      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n```\n\nAfter, works","shortMessageHtmlLink":"fix eden cmake missing eden/common/utils/DirType.h"}},{"before":"4a37bcbd531c51d1e376ebf6b6aa103e93c65a11","after":"868e9499db9f291ee1cc674c1bf8730cd888b2f2","ref":"refs/heads/main","pushedAt":"2024-06-08T13:56:44.000Z","pushType":"push","commitsCount":2173,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"exclude firstline from body in new pr (#899)\n\nSummary:\n[github] exclude firstline from body in new pr\n\nPull Request resolved: https://github.com/facebook/sapling/pull/899\n\nReviewed By: sggutier\n\nDifferential Revision: D57843724\n\nPulled By: zzl0\n\nfbshipit-source-id: 314df6bf36f829f9bd9ca779a4db5e00e0e1a6d2","shortMessageHtmlLink":"exclude firstline from body in new pr (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2319628632\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/sapling/issues/899\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/sapling/pull/899/hovercard\" href=\"https://github.com/facebook/sapling/pull/899\">facebook#899</a>)"}},{"before":"32080aa46ae02834cfc3914e8b2d4a68560ac894","after":"4a37bcbd531c51d1e376ebf6b6aa103e93c65a11","ref":"refs/heads/main","pushedAt":"2024-02-24T19:54:05.000Z","pushType":"push","commitsCount":31,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/cachelib/commit/1b3a4867a3e1e4613f7b958a2aeeae5159a19f66\nhttps://github.com/facebook/fb303/commit/fe588ff738b640eb49b629d521ca22c9290751eb\nhttps://github.com/facebook/fbthrift/commit/a1ca956542989c14cea4f7224c4bbfd3d5973cce\nhttps://github.com/facebook/folly/commit/ff3463a6b459a4046d2bef3b231e32c8a3265d0e\nhttps://github.com/facebook/mcrouter/commit/55cda7aebdc207130c1182371a9cdf171af4e0fe\nhttps://github.com/facebook/mvfst/commit/1596979507c8d6b7e30ece02b68514d1b24b37a0\nhttps://github.com/facebook/proxygen/commit/b88e4f47064473bd546edcf80cc94cbacab457c7\nhttps://github.com/facebook/wangle/commit/d70f9fa509a8a6c45681fdcc907a0a24b71faa05\nhttps://github.com/facebook/watchman/commit/7d3517529d0d8ba07154003f851ead5fa5531c8e\nhttps://github.com/facebookexperimental/edencommon/commit/a0d6569d287eb490550d5b3b3669b6e5a31db75a\nhttps://github.com/facebookexperimental/rust-shed/commit/1657484135d04cdbf8a05b45e6cfd5d7a6f217fa\nhttps://github.com/facebookincubator/fizz/commit/10f6050d4112808eac2d3ab8a7b591eebdfad269\nhttps://github.com/facebookincubator/katran/commit/25d38a48068eb4b0fcaa11d584cab1bf2333c71b\n\nReviewed By: jailby\n\nfbshipit-source-id: 4f0cff0fbe0c74496408890c1a8ceb0c43b2ec6d","shortMessageHtmlLink":"Updating submodules"}},{"before":"d504f9ebb53305b26f073951d0f71f364b300e42","after":"32080aa46ae02834cfc3914e8b2d4a68560ac894","ref":"refs/heads/main","pushedAt":"2024-02-23T18:46:04.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"textmate: re-generate files\n\nSummary: Done by `yarn textmate`.\n\nReviewed By: evangrayk\n\nDifferential Revision: D54104071\n\nfbshipit-source-id: b24516c57ed2da9a58a38230d77d1d7dc0a67074","shortMessageHtmlLink":"textmate: re-generate files"}},{"before":"62abae7101f3ca1ffd48c02fb888c4328bd59464","after":"d504f9ebb53305b26f073951d0f71f364b300e42","ref":"refs/heads/main","pushedAt":"2024-02-23T14:07:23.000Z","pushType":"push","commitsCount":466,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"hooks: add convenience function for parsing options out of hook config\n\nSummary: This pattern is likely to be used in all hooks, so make it available as a method on `HookConfig`.\n\nReviewed By: liubov-dmitrieva\n\nDifferential Revision: D54114602\n\nfbshipit-source-id: 3da89175a6dff28bcbf9e1726cdb5b7564b0ac2b","shortMessageHtmlLink":"hooks: add convenience function for parsing options out of hook config"}},{"before":"371960a41628d3af8c92c97f3f6e7fcced1ef072","after":"7a5036227a2461701964e7b7f6ace6e4e2046db1","ref":"refs/heads/sapling-pr-archive-ahornby","pushedAt":"2024-02-06T17:49:31.000Z","pushType":"push","commitsCount":61,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"merge commit for archive created by Sapling","shortMessageHtmlLink":"merge commit for archive created by Sapling"}},{"before":null,"after":"aae93688ddbe7aa12f01f28d6d79e6f1e53bc209","ref":"refs/heads/pr833","pushedAt":"2024-02-06T17:49:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"github: update node to 18.x in docker image builds\n\nSummary:\n\nI noticed GitHub verify-addons CI failing with error\n\n```\nvite@5.1.0-beta.2: The engine \"node\" is incompatible with this module. Expected version \"^18.0.0 || >=20.0.0\". Got \"16.20.2\"\n```\n\nFrom sapling discord chat, likely this is due to recent replacement pof create-react-apps with vite for ISL.\n\nUpdate node to 18 on github to fix it.\n\nTest Plan:\n\nRun local docker builds and check nodejs version\n```\ndocker build -t sapling-cli-ubuntu-20.04 -f .github/workflows/sapling-cli-ubuntu-20.04.Dockerfile . &&\ndocker build -t sapling-cli-ubuntu-22.04 -f .github/workflows/sapling-cli-ubuntu-22.04.Dockerfile .\n```\n\nBefore:\n```\n$ docker run -ti sapling-cli-ubuntu-20.04 node --version\nv16.20.2\n$ docker run -ti sapling-cli-ubuntu-22.04 node --version\nv16.20.2\n```\n\nAfter:\n```\n$ docker run -ti sapling-cli-ubuntu-20.04 node --version\nv18.19.0\n$ docker run -ti sapling-cli-ubuntu-22.04 node --version\nv18.19.0\n```","shortMessageHtmlLink":"github: update node to 18.x in docker image builds"}},{"before":"0672e03c70a62812becd04c7f1759fae1fbcd2bc","after":"5794b3c8374745da3a3b7b802db361d51258cc87","ref":"refs/heads/eden_windows_ci","pushedAt":"2024-02-06T17:46:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"getdeps: fix confusing slash when patching on windows","shortMessageHtmlLink":"getdeps: fix confusing slash when patching on windows"}},{"before":"2c18239568cd38155a40ec9d6629c3d113d6ee6b","after":"62abae7101f3ca1ffd48c02fb888c4328bd59464","ref":"refs/heads/main","pushedAt":"2024-02-06T17:19:27.000Z","pushType":"push","commitsCount":59,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"S392603: git_move_bookmark: Stop swallowing important diagnostics\n\nSummary:\nIn S392603, live sync (specifically, `git_move_bookmark` in the `post-receive` git hook was failing for aosp/manifest.\n\nThis was due to missing ACL, but the most prominent error from the logs was about a missing branch, which was a red herring.\n\nThis is what the errors looked like:\n```\n999-update-mononoke-bookmark: Hook called for ref: refs/heads/feature-mos-11-validation-2024-02-05, old rev: f36c12574f28301755e2be5a400cf47e5ac1de78, new rev: d11378002b04fcad5b66cd351673c3ccfc3ac3d2\nError: SourceControlService::repo_move_bookmark failed with request_error(RequestError)\n\nCaused by:\n    RequestError: bookmark 'heads/feature-mos-11-validation-2024-02-05' does not exist\n```\n\nThis created confusion and slowed down root cause identification for this SEV.\n\nRefactor the code to be more explicit about the existence check we are doing. This removes the incorrect assumption that any error from `create_bookmark` must be due to the origin bookmark being absent, which leads to swallowing the real error.\n\nReviewed By: singhsrb\n\nDifferential Revision: D53473235\n\nfbshipit-source-id: e6382e593926a94bdc78364a97c58977a84dbc89","shortMessageHtmlLink":"S392603: git_move_bookmark: Stop swallowing important diagnostics"}},{"before":"a46b881a3349084e4beefcf12e4c48880408c822","after":"371960a41628d3af8c92c97f3f6e7fcced1ef072","ref":"refs/heads/sapling-pr-archive-ahornby","pushedAt":"2024-02-04T20:06:13.000Z","pushType":"push","commitsCount":1282,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"merge commit for archive created by Sapling","shortMessageHtmlLink":"merge commit for archive created by Sapling"}},{"before":null,"after":"fb37e9153b1711d71f689eb56d6c67e191f854fb","ref":"refs/heads/pr832","pushedAt":"2024-02-04T20:06:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix edenfs OSS build break on set[str]\n\nSummary:\nThe eden OSS build is failing due to set[str] not being valid on python 3.8.  Fix\nby import typing Set and using Set[str] like elsewhere in the code\n\nTest Plan:\n\nRun a build locally with:\n`/build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden`\n\nBefore\n```\nFAILED: eden/integration/hg/CMakeFiles/hg_integration_tests.GEN_PY_EXE.util eden/integration/hg/hg_integration_tests_tests.cmake\ncd /home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg && /usr/bin/cmake -D TEST_TARGET=hg_integration_tests -D TEST_INTERPRETER=/usr/bin/python3.8 -D TEST_ENV=CMAKE_SOURCE_DIR=/home/alex/local/sapling -D TEST_EXECUTABLE=/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests -D TEST_WORKING_DIR=/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden -D TEST_LIST=hg_integration_tests_TESTS -D TEST_PREFIX=hg_integration_tests:: -D TEST_PROPERTIES= -D CTEST_FILE=/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests_tests.cmake -P /home/alex/local/sapling/build/fbcode_builder/CMake/FBPythonTestAddTests.cmake\nTraceback (most recent call last):\n  File \"/usr/lib/python3.8/runpy.py\", line 194, in _run_module_as_main\n    return _run_code(code, main_globals, None,\n  File \"/usr/lib/python3.8/runpy.py\", line 87, in _run_code\n    exec(code, run_globals)\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 805, in <module>\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 801, in main\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 663, in run\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 646, in load_tests\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 443, in load_all\n  File \"<frozen importlib._bootstrap>\", line 991, in _find_and_load\n  File \"<frozen importlib._bootstrap>\", line 975, in _find_and_load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 655, in _load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 618, in _load_backward_compatible\n  File \"<frozen zipimport>\", line 259, in load_module\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/eden/integration/hg/filteredhg_test.py\", line 20, in <module>\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/eden/integration/hg/filteredhg_test.py\", line 107, in FilteredFSBase\nTypeError: 'type' object is not subscriptable\nCMake Error at /home/alex/local/sapling/build/fbcode_builder/CMake/FBPythonTestAddTests.cmake:27 (message):\n  Error running test executable:\n  /home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests\n```\n\nAfter, works","shortMessageHtmlLink":"fix edenfs OSS build break on set[str]"}},{"before":"695f82c5420505a06d23a74cf5e4a6caf6596cbb","after":"fb37e9153b1711d71f689eb56d6c67e191f854fb","ref":"refs/heads/fix_eden_oss","pushedAt":"2024-02-04T18:31:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix edenfs OSS build break on set[str]\n\nSummary:\nThe eden OSS build is failing due to set[str] not being valid on python 3.8.  Fix\nby import typing Set and using Set[str] like elsewhere in the code\n\nTest Plan:\n\nRun a build locally with:\n`/build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden`\n\nBefore\n```\nFAILED: eden/integration/hg/CMakeFiles/hg_integration_tests.GEN_PY_EXE.util eden/integration/hg/hg_integration_tests_tests.cmake\ncd /home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg && /usr/bin/cmake -D TEST_TARGET=hg_integration_tests -D TEST_INTERPRETER=/usr/bin/python3.8 -D TEST_ENV=CMAKE_SOURCE_DIR=/home/alex/local/sapling -D TEST_EXECUTABLE=/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests -D TEST_WORKING_DIR=/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden -D TEST_LIST=hg_integration_tests_TESTS -D TEST_PREFIX=hg_integration_tests:: -D TEST_PROPERTIES= -D CTEST_FILE=/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests_tests.cmake -P /home/alex/local/sapling/build/fbcode_builder/CMake/FBPythonTestAddTests.cmake\nTraceback (most recent call last):\n  File \"/usr/lib/python3.8/runpy.py\", line 194, in _run_module_as_main\n    return _run_code(code, main_globals, None,\n  File \"/usr/lib/python3.8/runpy.py\", line 87, in _run_code\n    exec(code, run_globals)\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 805, in <module>\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 801, in main\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 663, in run\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 646, in load_tests\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 443, in load_all\n  File \"<frozen importlib._bootstrap>\", line 991, in _find_and_load\n  File \"<frozen importlib._bootstrap>\", line 975, in _find_and_load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 655, in _load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 618, in _load_backward_compatible\n  File \"<frozen zipimport>\", line 259, in load_module\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/eden/integration/hg/filteredhg_test.py\", line 20, in <module>\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/eden/integration/hg/filteredhg_test.py\", line 107, in FilteredFSBase\nTypeError: 'type' object is not subscriptable\nCMake Error at /home/alex/local/sapling/build/fbcode_builder/CMake/FBPythonTestAddTests.cmake:27 (message):\n  Error running test executable:\n  /home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests\n```\n\nAfter, works","shortMessageHtmlLink":"fix edenfs OSS build break on set[str]"}},{"before":"54107ecb4ca38c7b21330b7f42f2b88bd36419a9","after":"2c18239568cd38155a40ec9d6629c3d113d6ee6b","ref":"refs/heads/main","pushedAt":"2024-02-04T18:30:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/cachelib/commit/e040b5d3629b9f69dc15f9c680d88ed44dc2c93f\nhttps://github.com/facebook/fb303/commit/3091c9593e332745b02f59249242547ac0902c65\nhttps://github.com/facebook/fbthrift/commit/03c2fd0a4d23ba8ed9ecd7cd65f9956d4ca9787d\nhttps://github.com/facebook/folly/commit/718e60213d159401916acc932c1f3766aad3beb8\nhttps://github.com/facebook/mvfst/commit/6362aaffeba6a9a2e922043ca2f58f7f0b1bcbf9\nhttps://github.com/facebook/proxygen/commit/9cd5d3fef0de9f9ce8cdd6ca6ba6e39bf102284a\nhttps://github.com/facebook/wangle/commit/2d07ba7485e2f67685c38541e2931664ffe2cbdc\nhttps://github.com/facebook/watchman/commit/9251157b9fe0e1af772af4d096939a67bb0127cd\nhttps://github.com/facebookexperimental/edencommon/commit/17b269fcbb7ad796befe7e5bdcb67964ac0fe641\nhttps://github.com/facebookexperimental/rust-shed/commit/2335e047b45e99a98eab5c345f4bce3abdab6f30\nhttps://github.com/facebookincubator/fizz/commit/4c5850481df9598253576189be3adc5e959f59dc\nhttps://github.com/facebookincubator/katran/commit/631dc400c8ccd14263acfa36862b99fe2917d6b0\nhttps://github.com/facebookincubator/superconsole/commit/5f1b4079b15b5988a8c18fef8618d34428852e54\nhttps://github.com/facebookincubator/velox/commit/735b8f4c0feb73f93bfe1983abd348fdfb2c451f\nhttps://github.com/pytorch/fbgemm/commit/dad9720397a4ceb13da32127f97c515e9a8c8d26\n\nReviewed By: jailby\n\nfbshipit-source-id: be997aa3d80d7feff156d30e2168581eeae1be6d","shortMessageHtmlLink":"Updating submodules"}},{"before":"b70c6579af528e83c7ef7ef688764971e8481efc","after":"695f82c5420505a06d23a74cf5e4a6caf6596cbb","ref":"refs/heads/fix_eden_oss","pushedAt":"2024-02-04T18:28:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix edenfs OSS build break on set[str]\n\nSummary:\nThe eden OSS build is failing due to set[str] not being valid on python 3.8.  Fix\nby import typing Set and using Set[str] like elsewhere in the code\n\nTest Plan:\n\nRun a build locally with:\n`/build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden`\n\nBefore\n```\nFAILED: eden/integration/hg/CMakeFiles/hg_integration_tests.GEN_PY_EXE.util eden/integration/hg/hg_integration_tests_tests.cmake\ncd /home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg && /usr/bin/cmake -D TEST_TARGET=hg_integration_tests -D TEST_INTERPRETER=/usr/bin/python3.8 -D TEST_ENV=CMAKE_SOURCE_DIR=/home/alex/local/sapling -D TEST_EXECUTABLE=/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests -D TEST_WORKING_DIR=/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden -D TEST_LIST=hg_integration_tests_TESTS -D TEST_PREFIX=hg_integration_tests:: -D TEST_PROPERTIES= -D CTEST_FILE=/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests_tests.cmake -P /home/alex/local/sapling/build/fbcode_builder/CMake/FBPythonTestAddTests.cmake\nTraceback (most recent call last):\n  File \"/usr/lib/python3.8/runpy.py\", line 194, in _run_module_as_main\n    return _run_code(code, main_globals, None,\n  File \"/usr/lib/python3.8/runpy.py\", line 87, in _run_code\n    exec(code, run_globals)\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 805, in <module>\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 801, in main\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 663, in run\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 646, in load_tests\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/__main__.py\", line 443, in load_all\n  File \"<frozen importlib._bootstrap>\", line 991, in _find_and_load\n  File \"<frozen importlib._bootstrap>\", line 975, in _find_and_load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 655, in _load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 618, in _load_backward_compatible\n  File \"<frozen zipimport>\", line 259, in load_module\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/eden/integration/hg/filteredhg_test.py\", line 20, in <module>\n  File \"/home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests/eden/integration/hg/filteredhg_test.py\", line 107, in FilteredFSBase\nTypeError: 'type' object is not subscriptable\nCMake Error at /home/alex/local/sapling/build/fbcode_builder/CMake/FBPythonTestAddTests.cmake:27 (message):\n  Error running test executable:\n  /home/alex/local/tmp/ubuntu-20.04/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/hg/hg_integration_tests\n```\n\nAfter, works","shortMessageHtmlLink":"fix edenfs OSS build break on set[str]"}},{"before":"4c94648d65ae6fe10066c530612d5bd2bef1b34a","after":"54107ecb4ca38c7b21330b7f42f2b88bd36419a9","ref":"refs/heads/main","pushedAt":"2024-02-04T17:11:21.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Bug fixes for ls-refs command output\n\nSummary:\nWhen I tried making use of the `LsRefsResponse` object for serving `ls-refs` requests through Git, I realized that the implementation had bugs:\n- When writing the refs to packet line output the format should be `object_id name metadata` instead of the existing `name object_id metadata`\n- When filtering refs based on the provided ref prefixes, we first need to ensure that we format the bookmarks as refs so that the matching can be done properly (i.e. matching with `refs/heads/abc` instead of `heads/abc`)\n- The symref target should contains the name of the ref that the symref points to. Currently it contained the symref name itself (i.e. `HEAD` had target as `HEAD` instead of `refs/heads/master`)\n\nReviewed By: mitrandir77\n\nDifferential Revision: D53268716\n\nfbshipit-source-id: 8b7060a11b09231bdf46ada251c369b72f70ed3a","shortMessageHtmlLink":"Bug fixes for ls-refs command output"}},{"before":"47bda6b8fa7e3de3bc4e795b007c78ac44437320","after":"0672e03c70a62812becd04c7f1759fae1fbcd2bc","ref":"refs/heads/eden_windows_ci","pushedAt":"2024-02-03T14:15:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"getdeps: fix confusing slash when patching on windows","shortMessageHtmlLink":"getdeps: fix confusing slash when patching on windows"}},{"before":"2c5788bf5301850cd7808743eb0e8146dbdf3240","after":"4c94648d65ae6fe10066c530612d5bd2bef1b34a","ref":"refs/heads/main","pushedAt":"2024-02-03T14:14:57.000Z","pushType":"push","commitsCount":615,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"shelve: fix a bug when unshelving new added files\n\nSummary: The files returned from `shelvectx.files())` are relative paths against the repo root, if user is not in the repo root directory, the `rename` operation will be failed with `No such file or directory` error, which is misleading.\n\nReviewed By: muirdm\n\nDifferential Revision: D53365058\n\nfbshipit-source-id: 974356c4a6fb527ad594e5c00ba991c14d0aa263","shortMessageHtmlLink":"shelve: fix a bug when unshelving new added files"}},{"before":"9c4413519f21f2656fa04bb9a70f53485fbd4973","after":"2c5788bf5301850cd7808743eb0e8146dbdf3240","ref":"refs/heads/main","pushedAt":"2023-12-31T12:29:06.000Z","pushType":"push","commitsCount":17,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/cachelib/commit/0ddefc601ee085d4c8c1752c8e67a416525c3dba\nhttps://github.com/facebook/fb303/commit/3c4ed497d51e2b6e504f7881943ce0a4d658c5e6\nhttps://github.com/facebook/fbthrift/commit/cdb212df4d196fb3578504ea2209338c1401757b\nhttps://github.com/facebook/folly/commit/234d39a36a43106747d10cc19efada72fd810dd3\nhttps://github.com/facebook/mvfst/commit/d25603b5859994463d38bf413ea5f4f84de128db\nhttps://github.com/facebook/proxygen/commit/fe2f38b41be67d0c1486b8fb9a7d67af6bbf6efe\nhttps://github.com/facebook/rocksdb/commit/06e593376cd5bc6990580f6cf6f4be1461c06614\nhttps://github.com/facebook/wangle/commit/ebbe643fba6d14e2572cf1576d5a2011417785b5\nhttps://github.com/facebook/watchman/commit/04ede129c6131de66ecdd1f9891f9406d16ee6c6\nhttps://github.com/facebookexperimental/edencommon/commit/af5725d0dbec6bc7bef1c81fbaaf33d48e44ff18\nhttps://github.com/facebookexperimental/rust-shed/commit/f9dfa61321c9633f9018ff2ca044a4ae228dbaf2\nhttps://github.com/facebookincubator/fizz/commit/935d6fec8592a38d0c0f33b6cd9c6f01dffb3b33\nhttps://github.com/facebookincubator/katran/commit/59f7e15c5801778f870604ae0384936892525f45\nhttps://github.com/facebookincubator/velox/commit/aae50540fbd256f90293348ef8f2b4d817458d6f\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: 3957fcbce50458195d64660179075e3f98c32c42","shortMessageHtmlLink":"Updating submodules"}},{"before":"06256bcdd2a121785ea602a9d27169a907c7c2a3","after":"47bda6b8fa7e3de3bc4e795b007c78ac44437320","ref":"refs/heads/eden_windows_ci","pushedAt":"2023-12-27T17:03:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"getdeps: fix confusing slash when patching on windows","shortMessageHtmlLink":"getdeps: fix confusing slash when patching on windows"}},{"before":"b4efffb2bb995ffc5db1038390bdb6f661edecb8","after":"06256bcdd2a121785ea602a9d27169a907c7c2a3","ref":"refs/heads/eden_windows_ci","pushedAt":"2023-12-27T16:50:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix edenfs windows build and add CI for it\n\none of my previous GCC 13+ fixes broke windows build internally which geneivive was kind enough to fix, but I couldn't see it in OSS as github didn't have a windows build so I've added CI for it.\n\nI found a few other problems with windows cmake build along the way. Here are the build fixes and the CI to show they work.\n\n  * upgrade ninja to fix problem finding make_fbpy_archive.py on windows VS build tools 2019 & 2022\n\n  * upgrade libsodium to a version with VS 2019 binaries.\n\n  * patch lmdb to build with cmake on windows as its makefile is not windows compatible\n\nTest plan:\n\nfor make_fbpy_archive.py: test locally in the git base window with: python build/fbcode_builder/getdeps.py build --clean python-six`\n\nBefore: `ninja: error: 'C:/Users/alex/local/sapling/build/fbcode_builder/CMake/make_fbpy_archive.py', needed by 'python-six.lib_install/python-six.manifest', missing and no known rule to make it`\n\nAfter, works\n\nfor libsodium upgrade: test locally with: python build/fbcode_builder/getdeps.py build fizz\n\nBefore, fails on not finding VS 2019 compatible libsodium\n\nAfter, works\n\nFor lmdb cmake windows build: test locally with: python build/fbcode_builder/getdeps.py build lmdb\n\n\n\nadd eden fs windows build\n\nmake it visible if this builds is breaking","shortMessageHtmlLink":"fix edenfs windows build and add CI for it"}},{"before":"d04cd73f68e1a69229734af33d1da2056730824f","after":"9c4413519f21f2656fa04bb9a70f53485fbd4973","ref":"refs/heads/main","pushedAt":"2023-12-27T16:50:33.000Z","pushType":"push","commitsCount":22,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/cachelib/commit/ffb2bb43f7805d8cb3954ded273d1b003d421d5f\nhttps://github.com/facebook/fb303/commit/4eabc4ba5db2a0f41e7146f216a08eaf1f69131e\nhttps://github.com/facebook/fbthrift/commit/62d48b95516fca25b520520f3ac0b9453b865065\nhttps://github.com/facebook/proxygen/commit/d493821f7f4344995dca28f54b6cff20d7a5c686\nhttps://github.com/facebook/watchman/commit/3cc2a5a0b676cb88b7fb817aeee83de8568b1263\nhttps://github.com/facebookexperimental/rust-shed/commit/63b6ff40254b428f86401818ab2a62cf0b05baac\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: 092d38d85c175f03c516748ef32b4d92ab3ab4c4","shortMessageHtmlLink":"Updating submodules"}},{"before":"60b255fe27302b814571bfee46948270a718e5a2","after":"b4efffb2bb995ffc5db1038390bdb6f661edecb8","ref":"refs/heads/eden_windows_ci","pushedAt":"2023-12-27T16:46:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix edenfs windows build and add CI for it\n\none of my previous GCC 13+ fixes broke windows build internally which geneivive was kind enough to fix, but I couldn't see it in OSS as github didn't have a windows build so I've added CI for it.\n\nI found a few other problems with windows cmake build along the way. Here are the build fixes and the CI to show they work.\n\n  * upgrade ninja to fix problem finding make_fbpy_archive.py on windows VS build tools 2019 & 2022\n\n  * upgrade libsodium to a version with VS 2019 binaries.\n\n  * patch lmdb to build with cmake on windows as its makefile is not windows compatible\n\nTest plan:\n\nfor make_fbpy_archive.py: test locally in the git base window with: python build/fbcode_builder/getdeps.py build --clean python-six`\n\nBefore: `ninja: error: 'C:/Users/alex/local/sapling/build/fbcode_builder/CMake/make_fbpy_archive.py', needed by 'python-six.lib_install/python-six.manifest', missing and no known rule to make it`\n\nAfter, works\n\nfor libsodium upgrade: test locally with: python build/fbcode_builder/getdeps.py build fizz\n\nBefore, fails on not finding VS 2019 compatible libsodium\n\nAfter, works\n\nFor lmdb cmake windows build: test locally with: python build/fbcode_builder/getdeps.py build lmdb\n\n\n\nadd eden fs windows build\n\nmake it visible if this builds is breaking","shortMessageHtmlLink":"fix edenfs windows build and add CI for it"}},{"before":null,"after":"b97fa7f2f59f20ea0439c8daf87e20109ab9da09","ref":"refs/heads/reviewstack.dev-prod","pushedAt":"2023-12-21T00:03:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: d04cd73f68e1a69229734af33d1da2056730824f","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/ahornby/sapling/commit/d04cd73f68e1a69229734af33d1da2056730824f/hovercard\" href=\"https://github.com/ahornby/sapling/commit/d04cd73f68e1a69229734af33d1da2056730824f\"><tt>d04cd73</tt></a>"}},{"before":"d34d2d4c24b7381a34731d2f34044a4c8fa283fb","after":"d04cd73f68e1a69229734af33d1da2056730824f","ref":"refs/heads/main","pushedAt":"2023-12-20T12:08:27.000Z","pushType":"push","commitsCount":25,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"update pem to 3.0.3\n\nSummary: A new version of `pem` is needed as part of the resolution to S362947. Updating to version 3.0.2 as was recommended here: https://fb.workplace.com/groups/402454550753394/posts/1097988554533320/?comment_id=1099994860999356&reply_comment_id=1100666984265477\n\nReviewed By: zertosh\n\nDifferential Revision: D52297455\n\nfbshipit-source-id: d39b132fcf0bdef3b4d48ef13fca7ba3147d827c","shortMessageHtmlLink":"update pem to 3.0.3"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEgKNf8QA","startCursor":null,"endCursor":null}},"title":"Activity · ahornby/sapling"}