Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 18 commits
- 18 files changed
- 1 contributor
Commits on Jul 15, 2023
-
The variable "matched" has not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
-
Refactor mergeOptions in utils\object.js
In this commit, I tried to make the code more cleaner by: - using the spread syntax to simplify the Object.assign method. This combines the default classes with the settings classes using the spread operator to create a new object that contains all the properties. - using a loop and square brackets notation, to merge all properties in a dynamic way, instead of adding each one with a lot of duplicate code.
-
Refactor throttle in utils\wait.js
In this commit, I tried to make the code more cleaner by: - using "const" instead of "let" with unassignable functions. - using default parameter instead of using "if no options".
-
The variables have not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
-
The variable has not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
-
The variable has not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
-
The variables have not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
-
- The variables have not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment. - Using "slides.length > 0" is cleaner than "slides.length !== 0" because the second one means "(slides.length > 0) || slides.length < 0", and it can't be less than zero.
-
- The variables have not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment. - In line 92, we return if there is no item, so there is no need to check for item again in line 96. - in removeClass, we can simplify this if statement by using optional chaining operator.
-
The variable has not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
-
The variables have not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
-
- Highlighting the difference between the two different statements by creating an object that contains both the symbols. - Using "includes" for a more dynamic and readable condition. - Using square brackets notation to avoid duplicate code.
-
The variables have not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
-
The variables have not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
-
The variables have not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
-
The variables have not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
-
- The variables have not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment. - Removing "NOT" from if statement to make it more readable.
-
The variable has not been reassigned a value, so it's better to use "const" instead of "let", to prevent any unexpected behavior that may occur due to unintended assignment.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master