Fixed race condition when cancelling acquire() in Lock or Semaphore #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
reviewed
Nov 14, 2021
src/anyio/from_thread.py
Outdated
| @@ -82,7 +82,6 @@ async def run_async_cm(self) -> Optional[bool]: | |||
| value = await self._async_cm.__aenter__() | |||
| except BaseException as exc: | |||
| self._enter_future.set_exception(exc) | |||
| raise | |||
There was a problem hiding this comment.
Whoa, how did that get into the PR...must've been an artifact of my work on that other PR. Good job noticing this!
agronholm
commented
Nov 14, 2021
graingert
approved these changes
Nov 16, 2021
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387.