Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchanger doesn't check if the new options are different before using the cache #49

Open
PMajesty opened this issue Nov 27, 2019 · 0 comments

Comments

@PMajesty
Copy link

PMajesty commented Nov 27, 2019

If you try to validate an email address without dns_lookup: :off option before trying to validate it again, but now using the option dns_lookup: :off, the gem will still try to validate by DNS, because this line doesn't check if the config is any different before deleting the proposed host:

if @host_cache.has_key?(host)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant