-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having 3 different executables is confusing. #22
Comments
aestimo_poisson1d is used as a library for Poisson and DD solvers (scheme 7 and 8) (not executable file).
Cython option is helpful for creating fast .pyd importing functions library. I will remove duplicated and unused functions and rearrange them gradually.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have 3 different executables:
aestimo.py For electron solutions only
aestimo_eh.py with using k.p theorem, it can do solutions for holes.
aestimo_poisson1d I really do not know much about this. It is some codes translated from a book as I understand.
aestimo_eh.py can be used like aestimo.py, but if you want you can use it as a library. But it is not true for aestimo.py.
So, these things are quite confusing. @robochat and @h-hebal is it possible to write your opinions about the unification of these three files and maintain a simple usage? We can remove cython parts if necessary because our simulations are not time-consuming and pure python can run well.
If you can help to simplify the code, then we can change our working type from "directly commit to master branch" to "create pull-request first". And we can continue with small steps.
The text was updated successfully, but these errors were encountered: