Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize code examples #10

Open
halfbyte opened this issue Oct 25, 2022 · 0 comments
Open

Modernize code examples #10

halfbyte opened this issue Oct 25, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@halfbyte
Copy link
Collaborator

A lot of the code examples in the README are using oldish EmberObject syntax and should probably be replaced by examples in ES-Class syntax.

Also, examples where auto injection is implied should contain the necessary service injection.
@halfbyte halfbyte added documentation Improvements or additions to documentation good first issue Good for newcomers labels Oct 25, 2022
@mpminardi mpminardi mentioned this issue Nov 28, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@halfbyte