Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][a11y]: Card action menu button should have label #3388

Closed
1 task done
majornista opened this issue Jun 28, 2023 · 0 comments · Fixed by #4164
Closed
1 task done

[Bug][a11y]: Card action menu button should have label #3388

majornista opened this issue Jun 28, 2023 · 0 comments · Fixed by #4164
Labels
a11y Issues related to accessibility bug Something isn't working Component: Card Documentation good first issue Good for newcomers

Comments

@majornista
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Card

Expected behavior

No response

Actual behavior

In the Card documentation and storybook examples that include an action menu, the sp-action-menu should have a label attribute, or if not, a default label should be provided.

See:

<sp-action-menu slot="actions" placement="bottom-end" quiet>
<sp-menu-item>Deselect</sp-menu-item>
<sp-menu-item>Select Inverse</sp-menu-item>
<sp-menu-item>Feather...</sp-menu-item>
<sp-menu-item>Select and Mask...</sp-menu-item>
<sp-menu-divider></sp-menu-divider>
<sp-menu-item>Save Selection</sp-menu-item>
<sp-menu-item disabled>Make Work Path</sp-menu-item>
</sp-action-menu>
or
<sp-action-menu slot="actions" placement="bottom-end" quiet>
<sp-menu-item>Deselect</sp-menu-item>
<sp-menu-item>Select Inverse</sp-menu-item>
<sp-menu-item>Feather...</sp-menu-item>
<sp-menu-item>Select and Mask...</sp-menu-item>
<sp-menu-divider></sp-menu-divider>
<sp-menu-item>Save Selection</sp-menu-item>
<sp-menu-item disabled>Make Work Path</sp-menu-item>
</sp-action-menu>

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@majornista majornista added bug Something isn't working Component: Card a11y Issues related to accessibility triage An issue needing triage labels Jun 28, 2023
@najikahalsema najikahalsema added good first issue Good for newcomers Documentation and removed triage An issue needing triage labels Oct 26, 2023
@audknu audknu closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility bug Something isn't working Component: Card Documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants