Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure v12 should have fixed getAccessPolicy, replace custom code with azure sdk call #80

Open
moritzraho opened this issue Dec 9, 2020 · 2 comments
Open

azure v12 should have fixed getAccessPolicy, replace custom code with azure sdk call #80

moritzraho opened this issue Dec 9, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@moritzraho
Copy link
Member

Expected Behaviour

We should get rid of the custom implementation for getAccessPolicy https://github.com/adobe/aio-lib-files/blob/master/lib/impl/AzureBlobFiles.js#L200 and use the sdk for this.

This will require some careful testing (BYO too)
@moritzraho moritzraho added the bug Something isn't working label Dec 9, 2020
@aiojbot
Copy link
Collaborator

aiojbot commented Dec 9, 2020

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-986

@meryllblanchet meryllblanchet added enhancement New feature or request and removed bug Something isn't working labels Dec 9, 2020
@sandeep-paliwal
Copy link
Contributor

We need to make following changes

  1. remove getAccessPolicy API call and replace with v12 sdk call
  2. Above step needs to be done for File lib and TVM
  3. Check BYO works as expected post above changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@meryllblanchet @moritzraho @sandeep-paliwal @aiojbot