Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yahoo/Hotmail: Clicking formatting button breaks Markdown Toggle #16

Open
adam-p opened this issue Jun 20, 2012 · 2 comments
Open

Yahoo/Hotmail: Clicking formatting button breaks Markdown Toggle #16

adam-p opened this issue Jun 20, 2012 · 2 comments
Labels

Comments

@adam-p
Copy link
Owner

adam-p commented Jun 20, 2012

Reproduction:

  1. In Chrome (haven't confirmed Firefox) open the Yahoo mail editor.
  2. Type some text.
  3. Click the B (bold) button.
  4. Click back into the compose area.
  5. Right-click and click "Markdown Toggle".

Markdown Here's "The selected field is not valid for Markdown rendering. Please use a rich editor." will result.

The problem is that findFocusedElem() is finding the bold button instead of the compose box.

Not sure yet how to fix it. activeElement isn't an array, it's a single value, so it's not like there's a concept of more than one active element... even though the compose box clearly has focus. Maybe activeElement isn't the correct thing to use for finding the focused element?

Does each iframe have its own activeElement (that can all be meaningful at the same time)? Maybe all iframes should be traversed until a valid Markdown Here target is found?

Workaround: Click on the font size combo box and then back into the compose box. (Which makes no sense, but it works.)

This bug is especially bad since the "maintain pre-formatted text" feature was added, which encourages (or at least doesn't dissuade users) to click the formatting buttons.

@adam-p
Copy link
Owner Author

adam-p commented Jul 24, 2012

Dropping the high priority label, since the "maintain pre-formatted text" feature has been removed.

@adam-p
Copy link
Owner Author

adam-p commented Feb 6, 2013

There is a similar problem with Hotmail, except worse. If you tab from the Subject field to the email body, the activeElement gets stuck on the button for "bold". This seems to only happen in Chrome, and not Firefox.

On the upside, the new Yahoo interface may have fixed itself. I'm not sure yet, though.

Workaround: Click into the message body. If you tab into it, click out of it and then back in.

I have absolutely no idea how to fix this. I'm going to create a test page and ask on StackOverflow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant