Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ugly font bug when resetting OpenGL #210

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

veksha
Copy link
Contributor

@veksha veksha commented Sep 4, 2018

hello, guys. please, review this fix and consider to include in your repo.
thanks.
basically, it happens when you change video settings. white squares on loading screen appear instead of text.

@theonlypwner
Copy link
Member

I would probably fix this issue differently.

Since the fonts aren't loaded yet, "resetting OpenGL" is never visible after calls to loadingscreen in resetgl. I would remove the text in those calls and add extra loadingscreen calls to show loading messages for fonts, textures, and models.

theonlypwner added a commit that referenced this pull request Dec 9, 2020
@theonlypwner theonlypwner merged commit 3781fb2 into acreloaded:master Dec 9, 2020
@theonlypwner
Copy link
Member

theonlypwner commented Dec 9, 2020

Most of the time is spent loading textures, so I found that having a blank loading screen and adding text (1/3) after loading fonts and (2/3) after textures makes the most sense (see fc14cc9).

@veksha veksha deleted the fontbugfix branch December 9, 2020 04:50
@veksha
Copy link
Contributor Author

veksha commented Dec 9, 2020

3/3. bug closed. :)

@theonlypwner
Copy link
Member

It turns out that it is possible to start with resetting OpenGL (0/3), instead of just a blank loading screen (see 2cbfcdf).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants