[Statistics] Fix site statistics page loading #9354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@driusan tested on my end, but one automatic test failed. This is what I can see now, which looks good. |
|
@regisoc I think the test failure is an unrelated failure on the main branch.. I've already asked @kongtiaowang to look into it (tests were added that passed but I think there were incompatible changes on the main branch between the time the PR was sent and the time it was merged.) |
regisoc
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
I will approve it now because it looks good to me.
@kongtiaowang Let me know if this failed test is not linked to the mentioned incompatibility.
Fix type errors on the page loaded from the link on the LORIS dashboard for "data entry incomplete" in my tasks. Fixes aces#9353
12412be
to
34ba662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix type errors on the page loaded from the link on the LORIS dashboard for "data entry incomplete" in my tasks.
Fixes #9353