Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDB_BVL_Instrument] Test name should match CommentID #9314

Open
CamilleBeau opened this issue Jul 30, 2024 · 3 comments
Open

[NDB_BVL_Instrument] Test name should match CommentID #9314

CamilleBeau opened this issue Jul 30, 2024 · 3 comments
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@CamilleBeau
Copy link
Contributor

Describe the bug
Currently when instantiating an instrument with a Test_name and CommentID, the CommentID does not have to belong to the same instrument as the Test_name. As long as the Test_name exists in the database, it can be used as an argument for any CommentID.

There should be a warning or error thrown in these cases to ensure that the right Test_name is being passed as an argument to the factory method.

@CamilleBeau CamilleBeau added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Jul 30, 2024
@driusan
Copy link
Collaborator

driusan commented Aug 12, 2024

What is the current behaviour if they don't match/how is this coming up?

@CamilleBeau
Copy link
Contributor Author

What is the current behaviour if they don't match/how is this coming up?

@driusan If they don't match, it makes the instrument from the CommentID. This is coming up because we were making a script on CCNA that should have failed during testing as CommentIDs were being matched with different Test_names, but it did not.

@CamilleBeau
Copy link
Contributor Author

Still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

No branches or pull requests

2 participants