Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[imaging/database] Clean-up mri_protocol tables #9284

Open
maximemulder opened this issue May 29, 2024 · 0 comments · May be fixed by #9304
Open

[imaging/database] Clean-up mri_protocol tables #9284

maximemulder opened this issue May 29, 2024 · 0 comments · May be fixed by #9304
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation

Comments

@maximemulder
Copy link
Contributor

maximemulder commented May 29, 2024 •
edited
Loading

After discussing imaging with @nicolasbrossard and @ridz1208 this morning, we agreed the mri_protocol tables could use some clean-up :

  • In the mri_protocol_group_target table, the fields ProjectID, CohortID and Visit_label should have a UNIQUE constraint.
  • In the mri_protocol table, the field Scan_type should have a foreign key to the mri_scan_type.ID field (the current default to 0 is also quite suspicious).

Eventually, we could rename some fields to respect more accurately LORIS naming conventions.
@maximemulder maximemulder added the Cleanup PR or issue introducing/requiring at least one clean-up operation label May 29, 2024
@maximemulder maximemulder linked a pull request Jun 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[database] Clean up mri_scan_type maximemulder/Loris
1 participant
@maximemulder