-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dicom archive] Misleading database representation #9213
Comments
maximemulder
added
Bug
PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
and removed
Bug
PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
labels
Apr 22, 2024
This was discussed in today's (2024-04-23) meeting, everyone agrees it would make more sense to make this field nullable instead of using an empty string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While using the DICOM archive, I noticed that the field
CenterName
, in the tabletarchive
is not nullable. However, this field is often removed when deidentifying patients (such as with DICAT), and as such, it should be nullable in LORIS. The LORIS-MRI scripts currently use an empty string to represent a missing institution, but this is misleading, as it gives the impression that there is always a valid institution while it is in fact optionnal.I have not checked yet for other fields with the same problem, but it would not surprise me if there are others.
The text was updated successfully, but these errors were encountered: