[timepoint_list] Visit / approval stage display is broken

[CamilleBeau]

Describe the bug
If you modify the visit or approval stage from the timepoint list once, the stage display in the table to the right does not change. In any subsequent modifications without reloading the page, the display shows whatever the stage previously was. If the page is refreshed, the stage shows the correct status again.

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

1. Go to a visit that is passed
2. Click on "In Progress" stage in the lefthand sidebar without refreshing the page.
3. Notice that the stage in the display table to the right has not changed.
4. Without refreshing, click back to a different stage. Notice that now the display changes to "In Progress" even though a different stage was selected.
5. Refresh the page, and notice that the stage in the display table is now the correct one.

What did you expect to happen?
The display stage to be modified to match what is selected in the sidebar, and what is in the database.

[christinerogers]

I see this issue as simply that the page isn't dynamic. if you save a change, you have to refresh to see it take effect. I think this is a bigger question for making more pages/modules dynamic, probably too big for a summer student unless @driusan already has a plan in mind that can be quickly implemented.
thoughts @CamilleBeau ?

cc @racostas to be confirmed in a Loris meeting - maybe a good gsoc ticket if it's important and the solution is straightforward

[driusan]

Yes, the problem is that the page isn't dynamic. The update to the database happens after the page is rendered IIRC.

A summer student could probably do something so that the actions on the page result in a 303 Redirect to return to the page which would effectively be the same as the user re-loading the page without completely overhauling the module.

[CamilleBeau]

@christinerogers @driusan Yes, it's true that if you refresh it the correct value is shown. However, after selecting a new value, the whole page reloads and updates to the previously selected value. E.g. if it starts out as "Pass" and I select "In progress", it will reload as "Pass", and then if I select "Failure", it will reload as "In progress".

So it seems to be dynamic since the page refreshes and the variable is modified, but it is not modified to the correct value.

[christinerogers]

Hi @racostas and/or @CamilleBeau -- Could either of you please confirm:
Since this issue was resolved by CCNA#7223, could it likely be quickly resolved in LORIS by the same fix ?

Rolando --- if not, please 'remove' the GSOC tag I've just added. thanks

and generally, folks -- is it worth getting this bug fix in to the 26 release ?

[CamilleBeau]

@skarya22 Can you confirm if your fix is relevant to the 26 code?

[skarya22]

@christinerogers There are these two PRs that were merged into LORIS main.
#9040
#9072

I believe that the issue duplicated and this instance of it was resolved but not closed

[christinerogers]

already resolve, perfect. thank you all.