-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure --with-default-config-file=[FILE] create sub-directories #2112
Comments
If you specify
I would be very happy to create another configure option to specify the source location for a config file to be copied to the default config file path (possibly with |
Describe the bug
When the configure script uses the --with-default-config-file=[FILE] option and FILE points to a file in a specific sub-directory, the PATH to the file is created and installed. Easier to explain with an example. See below.
To Reproduce
Run the configure script with the --with-default-config-file option and point to a file in an absolute or relative path (I did relative). I'm also using --prefix for testing purposes.
Now, since our prefix is '/tmp/root/', the config file will be installed to '/tmp/root/etc/keepalived/./doc/samples/keepalived.conf.sample'. This is not at all what I expected. It seems that this configure option is a bit too literal. The way it works now it seems that you're only truly getting a default config file if you use "keepalived.conf" as the FILE.
Expected behavior
My expectation was that the path/file passed to --with-default-config-file would be installed to "$PREFIX/etc/keepalived/keepalived.conf" -- that is the default config file location. Instead, it created the exact path/file as specified.
Keepalived version
Additional context
Here is the full path:
I think it should be:
We could use something like 'basename' to strip the PATH, then the file should just be 'keepalived.conf'.
The text was updated successfully, but these errors were encountered: