Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensor fault detection #657

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Sensor fault detection #657

merged 7 commits into from
Jul 17, 2024

Conversation

daemonX10
Copy link
Contributor

@daemonX10 daemonX10 commented Jun 16, 2024 •
edited
Loading

Pull Request for ML-Crate 💡

Issue Title: End-to-end Sensor Fault Detection #644

  • Info about the related issue (Aim of the project) : The Sensor Fault Detection system is designed to monitor sensors and detect any faults. It uses advanced algorithms to ensure the accuracy and reliability of sensor data.
  • Name: Damodar Yadav
  • Email ID for further communication: [email protected]
  • GitHub ID: https://github.com/daemonX10
  • Idenitfy yourself: SSOC'24 contributor

Closes: #644

Describe the add-ons or changes you've made 📃\

  • Make the Model for Predication of condication of Sensor , it's good/Bad need replacement or not . I used various model for this and xgboost model out perform other and then done hyperparameter tunning.
  • Create PipeLine for data Ingestion , Data transformation , Model evaluation , Predication
  • Created Web app using Flask , django and Tailwind css and more

What sort of change have you made:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [✓] New feature (non-breaking change which adds functionality)
  • [ ] Code style update (formatting, local variables)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested

Describe how have you verified the changes made

Checklist: ☑️

  • [✓] My code follows the guidelines of this project.
  • [✓] I have performed a self-review of my own code.
  • [✓] I have commented my code, particularly wherever it was hard to understand.
  • [✓] I have made corresponding changes to the documentation.
  • [✓] My changes generate no new warnings.
  • [✓] I have added things that prove my fix is effective or that my feature works.
  • [✓] Any dependent changes have been merged and published in downstream modules.

@github-actions GitHub Actions
Copy link

Our team will soon review your PR. Thanks @daemonX10 :)

@daemonX10 daemonX10 changed the title Main Sensor fault detection Jun 17, 2024
abhisheks008
abhisheks008 requested changes Jun 19, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the project structure and make the changes accordingly.
@daemonX10

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Jun 19, 2024
@daemonX10
Copy link
Contributor Author

@abhisheks008 changes done . i have make new folder for web part and remaining dataset , model and notebook along with image in main folder

@abhisheks008
Copy link
Owner

In the web app folder create a README file (template: https://github.com/abhisheks008/ML-Crate/blob/main/.github/web-app-readme-template.md) and put a demonstration video of the working of the web app. Also attach the same video in the README so that others can view that easily.

@daemonX10
Copy link
Contributor Author

@abhisheks008 done those change in web readme file

@abhisheks008
Copy link
Owner

Just copy the demo video from your local system and paste the same inside the README so that it can be embedded inside the README and can also be viewed easily.
@daemonX10

@daemonX10
Copy link
Contributor Author

that video is available in img folder already @abhisheks008

@abhisheks008
Copy link
Owner

Although it is available in the img folder, we can not view that video directly. That's why I told you to do so in the above comment.

@daemonX10
Copy link
Contributor Author

@abhisheks008 added direct video embedding in readme

@abhisheks008
Copy link
Owner

image

Video is not visible. @daemonX10

@Harshit-code-tech
Copy link
Contributor

Harshit-code-tech commented Jul 7, 2024 •
edited
Loading

i have 4 things to ask...

  1. this is for local right??? how about web service deployment....it would be nice if you do that after submitting and completing on this...ofc on render or.. vercel..

  2. i would like to know theway of it's working...it must be really frustating to make.. because of tons of errors...right?

  3. what are it's limitations.. ?

  4. what's the best accuracy with val_loss?

@abhisheks008
Copy link
Owner

i have 4 things to ask...

  1. this is for local right??? how about web service deployment....it would be nice if you do that after submitting and completing on this...ofc on render or.. vercel..
  2. i would like to know theway of it's working...it must be really frustating to make.. because of tons of errors...right?
  3. what are it's limitations.. ?
  4. what's the best accuracy with val_loss?

@daemonX10 will explain this very well, as he is the one who is developing the whole thing. About the web app part, it is hosted in local. As a beginner when you are building a college project, locally hosted web app is enough, because majority of the college students used to take help from this project repository.

@daemonX10
Copy link
Contributor Author

i have 4 things to ask...

  1. this is for local right??? how about web service deployment....it would be nice if you do that after submitting and completing on this...ofc on render or.. vercel..
  2. i would like to know theway of it's working...it must be really frustating to make.. because of tons of errors...right?
  3. what are it's limitations.. ?
  4. what's the best accuracy with val_loss?

Local deployed, i have deployed multiple projects on render, you could ask me, although i have added all steps in Readme and the reason i don't deployed it, cause i not that much complex project.
2. NO, it's a simple project nothing more
3. Limitation, train on small dataset,
4. Val_loss check notebook

@daemonX10
Copy link
Contributor Author

IMG_20240707_194929
@abhisheks008 see, i have added video

@Harshit-code-tech
Copy link
Contributor

Harshit-code-tech commented Jul 7, 2024 •
edited
Loading

@daemonX10 to upload a video.. first go to any code issue tab.. in there from your local upload the video in chatbox...then github will provide a link..paste that in your readme note...

to check if your work or not.. go to file changed... in that .. go the the desired file... and click on 3 dots in right cornor of that particular...then view file...and then you can see what is visible to public

also... when used xgboost well..there is no issue in using decision tree..but it's no use when using xgboost...as it is the upgraded version of that

@abhisheks008
Copy link
Owner

@daemonX10 to upload a video.. first go to any code issue tab.. in there from your local upload the video in chatbox...then github will provide a link..paste that in your readme note...

to check if your work or not.. go to file changed... in that .. go the the desired file... and click on 3 dots in right cornor of that particular...then view file...and then you can see what is visible to public

also... when used xgboost well..there is no issue in using decision tree..but it's no use when using xgboost...as it is the upgraded version of that

Upload the video as mentioned @daemonX10

@daemonX10
Copy link
Contributor Author

daemonX10 commented Jul 10, 2024 •
edited
Loading

sensor.video.mp4

"https://github.com/abhisheks008/ML-Crate/assets/115637298/7712a38e-94b3-4463-ba65-c34f3e3a484d"
change the link @abhisheks008

@abhisheks008
Copy link
Owner

image

Still the video is not visible.

@daemonX10
Copy link
Contributor Author

Do check now @abhisheks008, it showing

abhisheks008
abhisheks008 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daemonX10 looks good to me. Approved ✅

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Advanced Points 40 - SSOC 2024 Ready To Merge 🚀 This PR is approved and ready to merge. and removed Requested Changes ⚙️ Some changes have been requested in this PR. Ready To Merge 🚀 This PR is approved and ready to merge. labels Jul 17, 2024
@abhisheks008 abhisheks008 merged commit ca8c06c into abhisheks008:main Jul 17, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jul 17, 2024
@abhisheks008
Copy link
Owner

Hi @daemonX10 have you registered in the OSLead portal?

@daemonX10
Copy link
Contributor Author

What is OSLead? @abhisheks008

@abhisheks008
Copy link
Owner

abhisheks008 commented Jul 20, 2024 •
edited
Loading

What is OSLead? @abhisheks008

You are part of SSOC and you don't know OSLead? Check out the announcement channel of the SSOC Discord server and register yourself in OSLead for leader board.

@daemonX10

@abhisheks008
Copy link
Owner

What is OSLead? @abhisheks008

You are part of SSOC and you don't know OSLead? Check out the announcement channel of the SSOC Discord server and register yourself in OSLead for leader board.

@daemonX10

Hi @daemonX10 have you done the needful?

@daemonX10
Copy link
Contributor Author

daemonX10 commented Jul 27, 2024 •
edited
Loading

I'm forgot that, can you give me link please @abhisheks008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhisheks008 abhisheks008 abhisheks008 approved these changes

Assignees

@daemonX10 daemonX10

Labels
Advanced Points 40 - SSOC 2024 Approved ✅ This PR is approved by the PR or, Mentors. Points Added 🎉 This issue's points has been added to the leaderboard. SSOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Project Addition] End-to-end Sensor Fault Detection
3 participants
@daemonX10 @abhisheks008 @Harshit-code-tech