Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer architecture/API #15

Open
abey79 opened this issue Apr 29, 2023 · 0 comments
Open

Viewer architecture/API #15

abey79 opened this issue Apr 29, 2023 · 0 comments
Labels
design-note Notes and reflections on design aspect

Comments

@abey79
Copy link
Owner

abey79 commented Apr 29, 2023

vsvg-viewer aims to offer a composable egui-based widget to display vsvg_core::Document in a GUI.

Here is a random list of considerations:

  • If used in vpype's show command, the viewer must be able to run/shutdown multiple times during execution. Apparently, this isn't yet possible with eframe on mac: eframe: create multiple windows in sequence emilk/egui#1918
  • run_native() doesn't make it easy to use RO refs (e.g. of a Document) in the closure. Because of that, I'm currently exposing DocumentData in the public API, but this should ideally be removed. Related issue: Allow the use of non-static App emilk/egui#2152
  • It's unclear to me how to handle error management in run_native()'s AppCreator function?
@abey79 abey79 added the design-note Notes and reflections on design aspect label Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design-note Notes and reflections on design aspect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abey79