Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is not logged out when logging in with new session #51

Open
giorgenes opened this issue Feb 29, 2024 · 3 comments
Open

User is not logged out when logging in with new session #51

giorgenes opened this issue Feb 29, 2024 · 3 comments

Comments

@giorgenes
Copy link

No sure if this is by design or not, but when I follow a magic link and a user is already logged in, the new user isn't logged in.

I believe the previous user should be logged off and the new user logged in instead.

@abevoelker
Copy link
Owner

That's definitely not by design! I'm traveling this week but should be able to dig in more by the end of the week / next weekend. Or, PRs gladly accepted to fix!

@drewlustro
Copy link

Also experiencing this! I tried to throw the following code in the magic link controller, but it does not work. Old session prevails.

class MagicLinksController < Devise::MagicLinksController
  skip_before_action :initialize_navigation_data

  def show
    Devise.sign_out_all_scopes ? sign_out : sign_out(resource_name)

    super
  end
end

@abevoelker
Copy link
Owner

(Copying and pasting this to all open issues/PRs:)

Hey all, per #64 I unfortunately won't have much time for the foreseeable future to maintain devise-passwordless to fix the open bugs and work on new features. I'm not abandoning this project, but due to some life issues it's just at the bottom of my priority list for now.

Anyone who wants to step up and be a maintainer to shepherd the project forward would be welcomed! I just ask that you've opened a PR, or written an issue, or can otherwise demonstrate some familiarity/competence with the project. You can reply to #64 or message me privately (through email or socials since GitHub doesn't have DMs) if interested. Thank you ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants