Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Ed25519 for keys #110

Open
zolagonano opened this issue Dec 21, 2021 · 14 comments
Open

Switch to Ed25519 for keys #110

zolagonano opened this issue Dec 21, 2021 · 14 comments

Comments

@zolagonano
Copy link

I saw this issue on HelloZeroNet, I think it's better to switch to Ed25519 and also keep the compatibility with ECDSA for old zero sites.

HelloZeroNet#2784

@canewsin
Copy link
Collaborator

canewsin commented Dec 22, 2021

I will visit this soon, currently reviewing @geekless some changes to pull to into this repo.

@canewsin
Copy link
Collaborator

canewsin commented Dec 22, 2021

If you have time, you can submit a pr with modifications

@canewsin
Copy link
Collaborator

@zolagonano I see you have some rust repos on your github, I suggest you to use zeronet cryptography crate https://crates.io/crates/zeronet_cryptography implement changes using rust, this will in turn improve signing speed for both old and new key versions.

@canewsin
Copy link
Collaborator

I was planning to port ZeroNet to rust in future so suggested the above.

@zolagonano
Copy link
Author

Unfortunately, I'm not familiar with ZeroNet's codebase yet

@canewsin
Copy link
Collaborator

@zolagonano You can look into zerunet repo incomplete rust implementation. will provide link

@canewsin
Copy link
Collaborator

@zolagonano
Copy link
Author

@zolagonano You can look into zerunet repo incomplete rust implementation. will provide link

Okay, also i can turn crate zeronet_cryptography into a python module (using PyO3 or rust-cpython) that can be used inside this fork to speed up signing or key generation process.

@canewsin
Copy link
Collaborator

canewsin commented Dec 22, 2021

Okay, also i can turn crate zeronet_cryptography into a python module (using PyO3 or rust-cpython) that can be used inside this fork to speed up signing or key generation process.

This is what I suggested, implement sign logic there and make ffi bindings.

@canewsin
Copy link
Collaborator

@zolagonano Are you interested in rust version of ZeroNet, started working on it.

@zolagonano
Copy link
Author

@zolagonano Are you interested in rust version of ZeroNet, started working on it.

Yeah, I am. But I don't know where to start.

@canewsin
Copy link
Collaborator

I will allow access to rust repo

@canewsin
Copy link
Collaborator

@zolagonano invitation sent.

@zolagonano
Copy link
Author

@zolagonano invitation sent.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants