Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package upgrade #14

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Package upgrade #14

merged 3 commits into from
Mar 8, 2019

Conversation

maniackcrudelis
Copy link
Contributor

@maniackcrudelis maniackcrudelis commented Mar 4, 2019 •
edited by zamentur
Loading

Problem

  • Global upgrade of the package.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) : ljf
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from a team March 4, 2019 16:20
kay0u
kay0u requested changes Mar 5, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the minimum version number :-)

manifest.json Outdated Show resolved Hide resolved
zamentur
zamentur approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@zamentur zamentur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
I read it carefully, I haven't seen any error and i learn the new upgrade_type tips. :)

@maniackcrudelis maniackcrudelis merged commit b7c1e64 into testing Mar 8, 2019
@maniackcrudelis maniackcrudelis deleted the package_upgrade branch March 8, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kay0u kay0u kay0u approved these changes

@zamentur zamentur zamentur approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maniackcrudelis @kay0u @zamentur